Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 897663003: [Android] Import Android's SwipeRefreshLayout (Closed)

Created:
5 years, 10 months ago by jdduke (slow)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, aurimas (slooooooooow), newt (away)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Import Android's SwipeRefreshLayout Pull the necessary files from Android's app compat library (v4) to reuse the SwipeRefreshLayout. This allows perfect reproduction of the platform pull-to-refresh style while accomodating differences inherent to Chrome's asynchonous input pipeline. Integration of and necessary changes to this effect will be performed in https://codereview.chromium.org/894193005/. License reviewed per http://www.chromium.org/developers/adding-3rd-party-libraries. BUG=428429 Committed: https://crrev.com/2205cea680e1df1d709c14788e4417d69e00080e Cr-Commit-Position: refs/heads/master@{#316266}

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Rebase #

Messages

Total messages: 20 (5 generated)
jdduke (slow)
Ted, this change is in anticipation of adopting the compat pull-to-refresh effect more or less ...
5 years, 10 months ago (2015-02-04 22:26:34 UTC) #2
jdduke (slow)
On 2015/02/04 22:26:34, jdduke wrote: > Ted, this change is in anticipation of adopting the ...
5 years, 10 months ago (2015-02-05 00:15:43 UTC) #3
jdduke (slow)
OK, spoke with epenner@ offline and it sounds like we're good to go here. Also ...
5 years, 10 months ago (2015-02-09 21:51:47 UTC) #4
Ted C
lgtm
5 years, 10 months ago (2015-02-09 22:04:24 UTC) #5
jdduke (slow)
cpu@: This addition is Android-specific, and is only required within the chrome/ layer. I'm happy ...
5 years, 10 months ago (2015-02-09 22:08:03 UTC) #7
jdduke (slow)
On 2015/02/09 22:08:03, jdduke wrote: > cpu@: This addition is Android-specific, and is only required ...
5 years, 10 months ago (2015-02-09 22:09:12 UTC) #8
Ted C
+newt -- for the location discussion. But I think third_party/ is consistent with the data ...
5 years, 10 months ago (2015-02-09 22:22:11 UTC) #10
jdduke (slow)
cpu@: Anything else you'd like to see here?
5 years, 10 months ago (2015-02-10 23:16:34 UTC) #11
cpu_(ooo_6.6-7.5)
location ok. need to state that license got reviewed, instructions here http://www.chromium.org/developers/adding-3rd-party-libraries
5 years, 10 months ago (2015-02-12 20:59:19 UTC) #12
jdduke (slow)
On 2015/02/12 20:59:19, cpu wrote: > location ok. > > need to state that license ...
5 years, 10 months ago (2015-02-12 21:08:07 UTC) #13
Daniel Berlin
lgtm for ostpr
5 years, 10 months ago (2015-02-13 18:12:19 UTC) #15
cpu_(ooo_6.6-7.5)
lgtm
5 years, 10 months ago (2015-02-13 19:12:27 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897663003/40001
5 years, 10 months ago (2015-02-13 19:23:29 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-13 20:00:32 UTC) #19
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 20:01:10 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2205cea680e1df1d709c14788e4417d69e00080e
Cr-Commit-Position: refs/heads/master@{#316266}

Powered by Google App Engine
This is Rietveld 408576698