Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 897663002: Deleting the forwarding header files base/debug/trace_event* (Closed)

Created:
5 years, 10 months ago by ssid
Modified:
5 years, 10 months ago
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deleting the forwarding header files base/debug/trace_event* Now that the migration of the tracing files is completed and all the tracing clients have been updated to point to base/trace_event/, it is safe to remove the forwarding headers from the old location. The only purpose of those headers, in fact, was to handle the renames in smaller CLs. The only thing left, at this point, is gradually renaming the namespaces, which is going to be handled in the upcoming CLs. See crrev.com/837303004 and the related bug for motivations. BUG=451032 TBR=jam@chromium.org,sky@chromium.org Committed: https://crrev.com/74a89f06ec7db49e1262847d4aba07ed87fd5930 Cr-Commit-Position: refs/heads/master@{#314357}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -84 lines) Patch
M base/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download
M base/base.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
D base/debug/trace_event.h View 1 chunk +0 lines, -14 lines 0 comments Download
D base/debug/trace_event_argument.h View 1 chunk +0 lines, -14 lines 0 comments Download
D base/debug/trace_event_impl.h View 1 chunk +0 lines, -14 lines 0 comments Download
D base/debug/trace_event_synthetic_delay.h View 1 chunk +0 lines, -14 lines 0 comments Download
D base/debug/trace_event_win.h View 1 chunk +0 lines, -14 lines 0 comments Download
M content/renderer/scheduler/task_queue_manager.cc View 1 chunk +0 lines, -2 lines 1 comment Download
M ipc/ipc_message.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/event_thread_evdev.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
ssid
This is CL for deleting the old files.
5 years, 10 months ago (2015-02-03 12:55:14 UTC) #2
Primiano Tucci (use gerrit)
LGTM, just one comment. Please reword the description of the CL (the title is fine). ...
5 years, 10 months ago (2015-02-03 14:35:10 UTC) #3
Primiano Tucci (use gerrit)
Dana, this is just a small cleanup. Can you PTAL? The files have been moved ...
5 years, 10 months ago (2015-02-03 17:11:55 UTC) #5
danakj
lgtm
5 years, 10 months ago (2015-02-03 17:18:33 UTC) #6
Primiano Tucci (use gerrit)
TBRing jam and sky for four diff lines in content, ipc and ui. probably not ...
5 years, 10 months ago (2015-02-03 17:22:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897663002/1
5 years, 10 months ago (2015-02-03 17:22:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 17:25:33 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 17:26:30 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74a89f06ec7db49e1262847d4aba07ed87fd5930
Cr-Commit-Position: refs/heads/master@{#314357}

Powered by Google App Engine
This is Rietveld 408576698