Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 897633003: Add macro for getting a PropertyAttributes for the runtime functions (Closed)

Created:
5 years, 10 months ago by arv (Not doing code reviews)
Modified:
5 years, 10 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add macro for getting a PropertyAttributes for the runtime functions Motivation: Cleanup BUG=None R=adamk LOG=N Committed: https://crrev.com/59525f07dfa4d80f168b33ee6459336bdc1e4184 Cr-Commit-Position: refs/heads/master@{#26440}

Patch Set 1 #

Patch Set 2 : One more rename #

Patch Set 3 : git rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -38 lines) Patch
M src/runtime/runtime-object.cc View 1 2 12 chunks +20 lines, -38 lines 0 comments Download
M src/runtime/runtime-utils.h View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
arv (Not doing code reviews)
One more rename
5 years, 10 months ago (2015-02-03 19:13:06 UTC) #1
arv (Not doing code reviews)
This depends on https://codereview.chromium.org/896643003/ I could change the order of these if you prefer.
5 years, 10 months ago (2015-02-03 19:13:59 UTC) #2
adamk
lgtm
5 years, 10 months ago (2015-02-03 19:20:39 UTC) #3
arv (Not doing code reviews)
git rebase
5 years, 10 months ago (2015-02-04 17:45:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897633003/40001
5 years, 10 months ago (2015-02-04 17:49:17 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-04 18:22:30 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 18:22:48 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/59525f07dfa4d80f168b33ee6459336bdc1e4184
Cr-Commit-Position: refs/heads/master@{#26440}

Powered by Google App Engine
This is Rietveld 408576698