Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: Source/core/dom/Position.cpp

Issue 897633002: RenderFlexibleBox should be treated as a candidate for visible position. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/events/key-events-in-editable-flexbox-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Position.cpp
diff --git a/Source/core/dom/Position.cpp b/Source/core/dom/Position.cpp
index e4d56f2eef5cf9056e96b40c1c478e6fed7ff663..eb069bf693e1814eb09806a0a67b6ac149b1bd91 100644
--- a/Source/core/dom/Position.cpp
+++ b/Source/core/dom/Position.cpp
@@ -855,7 +855,7 @@ bool Position::isCandidate() const
if (isHTMLHtmlElement(*m_anchorNode))
return false;
- if (renderer->isRenderBlockFlow()) {
+ if (renderer->isRenderBlockFlow() || renderer->isFlexibleBox()) {
Manuel Rego 2015/02/10 22:31:37 I think this is failing for grid too. Could you fi
Manuel Rego 2015/02/10 22:43:24 Mmmm, I've just realized that this won't make any
if (toRenderBlock(renderer)->logicalHeight() || isHTMLBodyElement(*m_anchorNode)) {
if (!Position::hasRenderedNonAnonymousDescendantsWithHeight(renderer))
return atFirstEditingPositionForNode() && !Position::nodeIsUserSelectNone(deprecatedNode());
« no previous file with comments | « LayoutTests/fast/events/key-events-in-editable-flexbox-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698