Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1114)

Issue 897573003: Fix annottation of FileEntry to Entry. (Closed)

Created:
5 years, 10 months ago by hirono
Modified:
5 years, 10 months ago
Reviewers:
yawano
CC:
mtomasz, chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix annottation of FileEntry to Entry. Previously new metadata related codes use FileEntry as an input type in the annotation, but it should be Entry because they can take DirectoryEntry also. BUG=410766 TEST=None Committed: https://crrev.com/30128b707a94ef2bc1cc38e7569e8def6b13dcf4 Cr-Commit-Position: refs/heads/master@{#314993}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata.js View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set.js View 8 chunks +9 lines, -9 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/new_metadata_provider.js View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
hirono
PTAL, thanks!
5 years, 10 months ago (2015-02-06 05:55:16 UTC) #2
yawano
lgtm. Thank you!
5 years, 10 months ago (2015-02-06 05:59:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897573003/20001
5 years, 10 months ago (2015-02-06 06:48:48 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-06 07:19:47 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 07:22:07 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/30128b707a94ef2bc1cc38e7569e8def6b13dcf4
Cr-Commit-Position: refs/heads/master@{#314993}

Powered by Google App Engine
This is Rietveld 408576698