Fix --max_old_space_size=4096 integer overflow.

Fix --max_old_space_size=4096 integer overflow.

BUG=v8:3857
LOG=N

Committed: https://crrev.com/a02d97e342b81526ec8ee058dd4d7612a6287d68
Cr-Commit-Position: refs/heads/master@{#26510}

[bnoordhuis, 2015-02-03 00:25:24]

ben@strongloop.com changed reviewers:
+ yangguo@chromium.org

[bnoordhuis, 2015-02-03 00:25:25]

This leaves FLAG_max_semi_space_size untouched because it's an int.  I assume
that's because it's not expected to be ever larger than a few MB?

A related issue is the ResourceConstraints class in include/v8.h.  Because it
uses ints, you can't create an isolate with a heap > 2 GB.  I didn't address
that here because it constitutes an ABI change and I'm not sure what the policy
on that is.

[Yang, 2015-02-03 08:13:31]

On 2015/02/03 00:25:25, bnoordhuis wrote:
> This leaves FLAG_max_semi_space_size untouched because it's an int.  I assume
> that's because it's not expected to be ever larger than a few MB?
> 
> A related issue is the ResourceConstraints class in include/v8.h.  Because it
> uses ints, you can't create an isolate with a heap > 2 GB.  I didn't address
> that here because it constitutes an ABI change and I'm not sure what the
policy
> on that is.

LGTM. I filed a bug regarding ResourceConstraints.

[Yang, 2015-02-04 13:35:26]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2015-02-04 13:36:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/897543002/1

[commit-bot: I haz the power, 2015-02-04 13:39:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-04 13:39:16]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8
(http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/359)

[Yang, 2015-02-04 13:45:04]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2015-02-04 13:45:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/897543002/1

[commit-bot: I haz the power, 2015-02-04 13:48:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-04 13:48:37]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8
(http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/361)

[bnoordhuis, 2015-02-05 00:20:42]

On 2015/02/04 13:48:37, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   v8_presubmit on tryserver.v8
> (http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/361)

I believe the presubmit check is failing because *@strongloop.com hasn't been
whitelisted yet?

[Yang, 2015-02-05 16:05:13]

On 2015/02/05 00:20:42, bnoordhuis wrote:
> On 2015/02/04 13:48:37, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   v8_presubmit on tryserver.v8
> > (http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/361)
> 
> I believe the presubmit check is failing because mailto:*@strongloop.com
hasn't been
> whitelisted yet?

Checking back with legal. Apparently they haven't processed the @strongloop.com
CCLA yet :/

[Yang, 2015-02-09 06:58:13]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2015-02-09 06:59:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/897543002/1

[commit-bot: I haz the power, 2015-02-09 07:00:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-09 07:01:10]

Patchset 1 (id:??) landed as
https://crrev.com/a02d97e342b81526ec8ee058dd4d7612a6287d68
Cr-Commit-Position: refs/heads/master@{#26510}

[bnoordhuis, 2015-03-17 00:25:54]

Yang, would it be possible to get this patch back-ported to the 4.1 and 4.2
branches?  It should apply cleanly.

I'd be happy to file CLs for those branches but I suspect there's a bit more to
it than just uploading a patch.

[Yang, 2015-03-17 10:56:05]

On 2015/03/17 00:25:54, bnoordhuis wrote:
> Yang, would it be possible to get this patch back-ported to the 4.1 and 4.2
> branches?  It should apply cleanly.
> 
> I'd be happy to file CLs for those branches but I suspect there's a bit more
to
> it than just uploading a patch.

This should already be in 4.2. I merged it to 4.1:
https://codereview.chromium.org/1009523003/