Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: pkg/analysis_server/test/services/completion/completion_test_util.dart

Issue 897483003: fix named param default value code completion (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/completion/completion_test_util.dart
diff --git a/pkg/analysis_server/test/services/completion/completion_test_util.dart b/pkg/analysis_server/test/services/completion/completion_test_util.dart
index d5b49a3d3c95f128849298f8eaf4ad95c5152118..6a19a2ea9b1064b0b3495fb28327c5316d22f84e 100644
--- a/pkg/analysis_server/test/services/completion/completion_test_util.dart
+++ b/pkg/analysis_server/test/services/completion/completion_test_util.dart
@@ -1532,7 +1532,7 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {
});
}
- test_ConditionalExpression_partial_thenExpression() {
+ test_ConditionalExpression_elseExpression() {
// SimpleIdentifier ConditionalExpression ReturnStatement
addSource('/testA.dart', '''
int T1;
@@ -1543,7 +1543,7 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {
int T2;
F2() { }
class B {int x;}
- class C {foo(){var f; {var x;} return a ? T^}}''');
+ class C {foo(){var f; {var x;} return a ? T1 : T^}}''');
computeFast();
return computeFull((bool result) {
// top level results are partially filtered based on first char
@@ -1553,7 +1553,7 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {
});
}
- test_ConditionalExpression_partial_thenExpression_empty() {
+ test_ConditionalExpression_elseExpression_empty() {
// SimpleIdentifier ConditionalExpression ReturnStatement
addSource('/testA.dart', '''
int T1;
@@ -1564,7 +1564,7 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {
int T2;
F2() { }
class B {int x;}
- class C {foo(){var f; {var x;} return a ? ^}}''');
+ class C {foo(){var f; {var x;} return a ? T1 : ^}}''');
computeFast();
return computeFull((bool result) {
assertNotSuggested('x');
@@ -1580,7 +1580,7 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {
});
}
- test_ConditionalExpression_elseExpression() {
+ test_ConditionalExpression_partial_thenExpression() {
// SimpleIdentifier ConditionalExpression ReturnStatement
addSource('/testA.dart', '''
int T1;
@@ -1591,7 +1591,7 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {
int T2;
F2() { }
class B {int x;}
- class C {foo(){var f; {var x;} return a ? T1 : T^}}''');
+ class C {foo(){var f; {var x;} return a ? T^}}''');
computeFast();
return computeFull((bool result) {
// top level results are partially filtered based on first char
@@ -1601,7 +1601,7 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {
});
}
- test_ConditionalExpression_elseExpression_empty() {
+ test_ConditionalExpression_partial_thenExpression_empty() {
// SimpleIdentifier ConditionalExpression ReturnStatement
addSource('/testA.dart', '''
int T1;
@@ -1612,7 +1612,7 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {
int T2;
F2() { }
class B {int x;}
- class C {foo(){var f; {var x;} return a ? T1 : ^}}''');
+ class C {foo(){var f; {var x;} return a ? ^}}''');
computeFast();
return computeFull((bool result) {
assertNotSuggested('x');
@@ -1759,6 +1759,25 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {
});
}
+ test_DefaultFormalParameter_named_expression() {
+ // DefaultFormalParameter FormalParameterList MethodDeclaration
+ addTestSource('''
+ foo() { }
+ void bar() { }
+ class A {a(blat: ^) { }}''');
+ computeFast();
+ return computeFull((bool result) {
+ expect(request.replacementOffset, completionOffset);
+ expect(request.replacementLength, 0);
+ assertSuggestLocalFunction('foo', null);
+ assertSuggestLocalMethod('a', 'A', null);
+ assertSuggestLocalClass('A');
+ assertSuggestImportedClass('String');
+ assertSuggestImportedFunction('identical', 'bool');
+ assertNotSuggested('bar');
+ });
+ }
+
test_ExpressionStatement_identifier() {
// SimpleIdentifier ExpressionStatement Block
addSource('/testA.dart', '''

Powered by Google App Engine
This is Rietveld 408576698