Refactored pixel format resize operations in media/video/capture into a function called VideoCaptu…

content/browser/renderer_host/media/video_capture_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/media/video_capture_controller.h"
 
 #include <map>
 #include <set>
 
 #include "base/bind.h"
@@ skipping 409 matching lines @@
   else if (rotation == 180)
     rotation_mode = libyuv::kRotate180;
   else if (rotation == 270)
     rotation_mode = libyuv::kRotate270;
 
   switch (frame_format.pixel_format) {
     case media::PIXEL_FORMAT_UNKNOWN:  // Color format not set.
       break;
     case media::PIXEL_FORMAT_I420:
       DCHECK(!chopped_width && !chopped_height);
+      DCHECK_EQ(frame_format.ImageAllocationSize(),

[mcasas, 2015/02/03 20:48:46]

Instead of reimplementing ImageAllocationSize() for
DCHECKing purposes, I'd test the result of that
method versus |length| input parameter. |length| 
should never be smaller than what is needed to hold
for a given pixel format, but it might be larger
due to padding and alignments.

You could add around l.487:
DCHECK_GE(length, frame_format.ImageAllocationSize());

+                (size_t) frame_format.frame_size.GetArea() * 3 / 2);
       origin_colorspace = libyuv::FOURCC_I420;
       break;
     case media::PIXEL_FORMAT_YV12:
       DCHECK(!chopped_width && !chopped_height);
+      DCHECK_EQ(frame_format.ImageAllocationSize(),
+                (size_t) frame_format.frame_size.GetArea() * 3 / 2);
       origin_colorspace = libyuv::FOURCC_YV12;
       break;
     case media::PIXEL_FORMAT_NV12:
       DCHECK(!chopped_width && !chopped_height);
+      DCHECK_EQ(frame_format.ImageAllocationSize(),
+                (size_t) frame_format.frame_size.GetArea() * 3 / 2);
       origin_colorspace = libyuv::FOURCC_NV12;
       break;
     case media::PIXEL_FORMAT_NV21:
       DCHECK(!chopped_width && !chopped_height);
+      DCHECK_EQ(frame_format.ImageAllocationSize(),
+                (size_t) frame_format.frame_size.GetArea() * 3 / 2);
       origin_colorspace = libyuv::FOURCC_NV21;
       break;
     case media::PIXEL_FORMAT_YUY2:
       DCHECK(!chopped_width && !chopped_height);
+      DCHECK_EQ(frame_format.ImageAllocationSize(),
+                (size_t) frame_format.frame_size.GetArea() * 2);
       origin_colorspace = libyuv::FOURCC_YUY2;
       break;
     case media::PIXEL_FORMAT_UYVY:
       DCHECK(!chopped_width && !chopped_height);
+      DCHECK_EQ(frame_format.ImageAllocationSize(),
+                (size_t) frame_format.frame_size.GetArea() * 2);
       origin_colorspace = libyuv::FOURCC_UYVY;
       break;
     case media::PIXEL_FORMAT_RGB24:
+      DCHECK_GE(frame_format.ImageAllocationSize(),
+                (size_t) frame_format.frame_size.GetArea() * 3);
       origin_colorspace = libyuv::FOURCC_24BG;
 #if defined(OS_WIN)
       // TODO(wjia): Currently, for RGB24 on WIN, capture device always
       // passes in positive src_width and src_height. Remove this hardcoded
       // value when nagative src_height is supported. The negative src_height
       // indicates that vertical flipping is needed.
       flip = true;
 #endif
       break;
     case media::PIXEL_FORMAT_ARGB:
       origin_colorspace = libyuv::FOURCC_ARGB;
       break;
     case media::PIXEL_FORMAT_MJPEG:
+      DCHECK_LE(frame_format.ImageAllocationSize(),
+                (size_t) frame_format.frame_size.GetArea() * 3);
       origin_colorspace = libyuv::FOURCC_MJPG;
       break;
     default:
       NOTREACHED();
   }
 
   libyuv::ConvertToI420(data,
                         length,
                         yplane,
                         yplane_stride,
@@ skipping 247 matching lines @@
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   int active_client_count = 0;
   for (ControllerClient* client : controller_clients_) {
     if (!client->paused)
       ++active_client_count;
   }
   return active_client_count;
 }
 
 }  // namespace content