Refactored pixel format resize operations in media/video/capture into a function called VideoCaptu…

content/browser/renderer_host/media/video_capture_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/media/video_capture_controller.h"
 
 #include <map>
 #include <set>
 
 #include "base/bind.h"
@@ skipping 451 matching lines @@
     case media::PIXEL_FORMAT_ARGB:
       origin_colorspace = libyuv::FOURCC_ARGB;
       break;
     case media::PIXEL_FORMAT_MJPEG:
       origin_colorspace = libyuv::FOURCC_MJPG;
       break;
     default:
       NOTREACHED();
   }
 
+  // Given length can be greater than the required buffer size when paddings are

[mcasas, 2015/02/04 23:02:39]

s/when paddings are applied or alignments are changed/ because of paddings
and/or alignments/

+  // applied or alignments are changed, but it cannot be less.
+  DCHECK_GE(static_cast<size_t>(length), frame_format.ImageAllocationSize());
+
   if (libyuv::ConvertToI420(data,
                             length,
                             yplane,
                             yplane_stride,
                             uplane,
                             uv_plane_stride,
                             vplane,
                             uv_plane_stride,
                             crop_x,
                             crop_y,
@@ skipping 247 matching lines @@
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   int active_client_count = 0;
   for (ControllerClient* client : controller_clients_) {
     if (!client->paused)
       ++active_client_count;
   }
   return active_client_count;
 }
 
 }  // namespace content