Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 897463004: Revert of Make the glyph array entries inline. (Closed)

Created:
5 years, 10 months ago by bsalomon
Modified:
5 years, 10 months ago
Reviewers:
herb_g, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Make the glyph array entries inline. (patchset #10 id:170001 of https://codereview.chromium.org/885903002/) Reason for revert: I suspect this is causing the off-by-one character issues that show up in gold.skia.org as of now. All the errors I've seen are on a Win7 bot. Example: good: https://gold.skia.org/img/images/35396bb0d299b81c0031dc0632a019d4.png bad: https://gold.skia.org/img/images/484e511f9e696d95031cd25aeae59da0.png Original issue's description: > Make the glyph array entries inline. > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/4c08f16b252a55e438a61f26e5581394ed177da1 TBR=mtklein@google.com,reed@google.com,herb@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/9bf4e5bbf6ca96042c0e0f5dca9a52a943f25716

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -151 lines) Patch
M src/core/SkGlyph.h View 2 chunks +4 lines, -10 lines 0 comments Download
M src/core/SkGlyphCache.h View 1 chunk +14 lines, -30 lines 0 comments Download
M src/core/SkGlyphCache.cpp View 6 chunks +131 lines, -111 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bsalomon
Created Revert of Make the glyph array entries inline.
5 years, 10 months ago (2015-02-03 05:05:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897463004/1
5 years, 10 months ago (2015-02-03 05:06:17 UTC) #2
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 05:06:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9bf4e5bbf6ca96042c0e0f5dca9a52a943f25716

Powered by Google App Engine
This is Rietveld 408576698