Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 897463003: Remove OpenJPEG header generator binary from PDFium build. (Closed)

Created:
5 years, 10 months ago by jam
Modified:
5 years, 10 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove OpenJPEG header generator binary from PDFium build. This is giving duplicate symbols for main when linking PDFium into Chromium. BUG=453844 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/615082de70c7fc18d46d0d1a03b62d0d76b1daa9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M pdfium.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
jam
5 years, 10 months ago (2015-02-03 03:14:07 UTC) #2
Tom Sepez
RS LGTM (If it links). Thanks.
5 years, 10 months ago (2015-02-03 17:08:46 UTC) #3
jam
5 years, 10 months ago (2015-02-03 17:12:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
615082de70c7fc18d46d0d1a03b62d0d76b1daa9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698