Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Issue 897423003: Componentize WebHistoryService (Closed)

Created:
5 years, 10 months ago by sdefresne
Modified:
5 years, 10 months ago
CC:
browser-components-watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, David Black, dhollowa+watch_chromium.org, donnd+watch_chromium.org, dougw+watch_chromium.org, extensions-reviews_chromium.org, Jered, jfweitz+watch_chromium.org, kmadhusu+watch_chromium.org, melevin+watch_chromium.org, rlp+watch_chromium.org, samarth+watch_chromium.org, skanuj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize WebHistoryService Instead of using the factories to retrieve the dependended upon keyed service, pass them explicitly to WebHistoryService from the WebHistoryServiceFactory. Fix the dependency of WebHistoryService to add the service used and to remove the service unused. Move file into //components/history/core/browser, remove unnecessary #include and fix files that did not #include all the files they used. BUG=371835, 454524 Committed: https://crrev.com/ff13143269bcc9010afc9490fc83147d5fad5a81 Cr-Commit-Position: refs/heads/master@{#316622}

Patch Set 1 #

Patch Set 2 : Fix crash 454524 by initializing request_context_ member variable #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -732 lines) Patch
M chrome/browser/extensions/api/hotword_private/hotword_private_apitest.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/history/DEPS View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/history/history_service.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/history/web_history_service.h View 1 chunk +0 lines, -165 lines 0 comments Download
D chrome/browser/history/web_history_service.cc View 1 chunk +0 lines, -479 lines 0 comments Download
M chrome/browser/history/web_history_service_factory.cc View 2 chunks +18 lines, -11 lines 0 comments Download
M chrome/browser/history/web_history_service_unittest.cc View 13 chunks +25 lines, -26 lines 0 comments Download
M chrome/browser/search/hotword_audio_history_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/hotword_service_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/history_ui.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/history_ui.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M components/history.gypi View 1 2 3 chunks +4 lines, -0 lines 0 comments Download
M components/history/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/history/core/browser/BUILD.gn View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
A + components/history/core/browser/web_history_service.h View 5 chunks +21 lines, -7 lines 0 comments Download
A + components/history/core/browser/web_history_service.cc View 1 11 chunks +37 lines, -33 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
sdefresne
This is a reland of https://codereview.chromium.org/882753002 with a fix for the crash introduced (http://crbug/454524). The ...
5 years, 10 months ago (2015-02-10 17:29:43 UTC) #2
droger
lgtm
5 years, 10 months ago (2015-02-11 12:31:08 UTC) #3
James Hawkins
lgtm
5 years, 10 months ago (2015-02-11 17:35:59 UTC) #4
Roger Tawa OOO till Jul 10th
lgtm for deps
5 years, 10 months ago (2015-02-11 18:10:14 UTC) #5
sdefresne
rlp: ping for - chrome/browser/extensions/api/hotword_private - chrome/browser/search/hotword_*
5 years, 10 months ago (2015-02-16 09:32:03 UTC) #6
sdefresne
rlp: ping?
5 years, 10 months ago (2015-02-17 10:17:54 UTC) #8
rpetterson
sorry, thought I had reviewed this before. LGTM
5 years, 10 months ago (2015-02-17 18:11:26 UTC) #9
sdefresne
On 2015/02/17 at 18:11:26, rlp wrote: > sorry, thought I had reviewed this before. > ...
5 years, 10 months ago (2015-02-17 18:12:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897423003/40001
5 years, 10 months ago (2015-02-17 18:13:22 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-17 19:23:27 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 19:24:13 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ff13143269bcc9010afc9490fc83147d5fad5a81
Cr-Commit-Position: refs/heads/master@{#316622}

Powered by Google App Engine
This is Rietveld 408576698