Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 897423002: Update {virtual,override,final} to follow C++11 style in net. (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
Reviewers:
Ryan Sleevi
CC:
cbentzel+watch_chromium.org, chromium-reviews, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style in net. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 Committed: https://crrev.com/e6c6db7d6e4f367f8a5205a034e972eea3a348c9 Cr-Commit-Position: refs/heads/master@{#314964}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -54 lines) Patch
M net/android/network_change_notifier_android.h View 1 chunk +5 lines, -5 lines 0 comments Download
M net/android/network_change_notifier_android.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M net/android/network_change_notifier_android_unittest.cc View 4 chunks +5 lines, -7 lines 0 comments Download
M net/android/network_change_notifier_factory_android.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/cert/cert_verify_proc_android.h View 1 chunk +8 lines, -8 lines 0 comments Download
M net/dns/dns_config_service_posix.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/proxy/proxy_config_service_android.h View 2 chunks +4 lines, -4 lines 0 comments Download
M net/proxy/proxy_config_service_android.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M net/proxy/proxy_config_service_android_unittest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M net/test/spawned_test_server/remote_test_server.h View 1 chunk +1 line, -1 line 0 comments Download
M net/test/spawned_test_server/spawner_communicator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/test/spawned_test_server/spawner_communicator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
5 years, 10 months ago (2015-02-06 01:06:15 UTC) #2
Ryan Sleevi
lgtm
5 years, 10 months ago (2015-02-06 01:47:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897423002/1
5 years, 10 months ago (2015-02-06 01:47:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 03:43:25 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 03:45:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6c6db7d6e4f367f8a5205a034e972eea3a348c9
Cr-Commit-Position: refs/heads/master@{#314964}

Powered by Google App Engine
This is Rietveld 408576698