chrome/browser/about_flags.cc - Issue 897413002: Add a finch experiment for different memory pressure management strategies in ChromeOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/about_flags.cc

Issue 897413002: Add a finch experiment for different memory pressure management strategies in ChromeOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/chromeos/memory_pressure_observer_chromeos.cc ('K') | « base/chromeos/memory_pressure_observer_chromeos.cc ('k') | chromeos/chromeos_switches.h » ('j') | content/browser/browser_main_loop.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/about_flags.cc

diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc

index a04939e65aeeb9bf58bbbf92f42a9238ff847f12..b1d76647fa929ecadd1ed3220f51e8139647632b 100644

--- a/chrome/browser/about_flags.cc

+++ b/chrome/browser/about_flags.cc

@@ -296,15 +296,19 @@ const Experiment::Choice kEnableGpuRasterizationChoices[] = {

#if defined(OS_CHROMEOS)

const Experiment::Choice kMemoryPressureThresholdChoices[] = {

- { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },

- { IDS_FLAGS_CONSERVATIVE_THRESHOLDS,

- chromeos::switches::kMemoryPressureThresholds, "1" },

- { IDS_FLAGS_AGGRESSIVE_CACHE_DISCARD_THRESHOLDS,

- chromeos::switches::kMemoryPressureThresholds, "2" },

- { IDS_FLAGS_AGGRESSIVE_TAB_DISCARD_THRESHOLDS,

- chromeos::switches::kMemoryPressureThresholds, "3" },

- { IDS_FLAGS_AGGRESSIVE_THRESHOLDS,

- chromeos::switches::kMemoryPressureThresholds, "4" },

+ { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },

+ { IDS_FLAGS_CONSERVATIVE_THRESHOLDS,

+ chromeos::switches::kMemoryPressureThresholds,

+ kConservativeThreshold },

+ { IDS_FLAGS_AGGRESSIVE_CACHE_DISCARD_THRESHOLDS,

+ chromeos::switches::kMemoryPressureThresholds,

+ kAggressiveCacheDiscardThreshold },

+ { IDS_FLAGS_AGGRESSIVE_TAB_DISCARD_THRESHOLDS,

+ chromeos::switches::kMemoryPressureThresholds,

+ kAggressiveTabDiscardThreshold },

+ { IDS_FLAGS_AGGRESSIVE_THRESHOLDS,

+ chromeos::switches::kMemoryPressureThresholds,

+ kAggressiveThreshold },

};

#endif