Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: chrome/browser/about_flags.cc

Issue 897413002: Add a finch experiment for different memory pressure management strategies in ChromeOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address the code review comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromeos/chromeos_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 0101b9eb02b9b0f4888cadcbbb6993641bbcd1ea..36db435b2777f053334b322b68f6a0798ddb05f3 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -296,15 +296,19 @@ const Experiment::Choice kEnableGpuRasterizationChoices[] = {
#if defined(OS_CHROMEOS)
const Experiment::Choice kMemoryPressureThresholdChoices[] = {
- { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
- { IDS_FLAGS_CONSERVATIVE_THRESHOLDS,
- chromeos::switches::kMemoryPressureThresholds, "1" },
- { IDS_FLAGS_AGGRESSIVE_CACHE_DISCARD_THRESHOLDS,
- chromeos::switches::kMemoryPressureThresholds, "2" },
- { IDS_FLAGS_AGGRESSIVE_TAB_DISCARD_THRESHOLDS,
- chromeos::switches::kMemoryPressureThresholds, "3" },
- { IDS_FLAGS_AGGRESSIVE_THRESHOLDS,
- chromeos::switches::kMemoryPressureThresholds, "4" },
+ { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
+ { IDS_FLAGS_CONSERVATIVE_THRESHOLDS,
+ chromeos::switches::kMemoryPressureThresholds,
+ chromeos::switches::kConservativeThreshold },
+ { IDS_FLAGS_AGGRESSIVE_CACHE_DISCARD_THRESHOLDS,
+ chromeos::switches::kMemoryPressureThresholds,
+ chromeos::switches::kAggressiveCacheDiscardThreshold },
+ { IDS_FLAGS_AGGRESSIVE_TAB_DISCARD_THRESHOLDS,
+ chromeos::switches::kMemoryPressureThresholds,
+ chromeos::switches::kAggressiveTabDiscardThreshold },
+ { IDS_FLAGS_AGGRESSIVE_THRESHOLDS,
+ chromeos::switches::kMemoryPressureThresholds,
+ chromeos::switches::kAggressiveThreshold },
};
#endif
« no previous file with comments | « no previous file | chromeos/chromeos_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698