Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 897373002: cc: Don't refer to layer render target when using property trees (Closed)

Created:
5 years, 10 months ago by enne (OOO)
Modified:
5 years, 10 months ago
Reviewers:
Ian Vollick, ajuma
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Don't refer to layer render target when using property trees This is a vestige of old UpdateDrawProperties and instead should go directly to the target_id on the transform node. Also, the root node was setting the target_id incorrectly because its transform_node_index was not set before being referenced. This is a fix contributing towards getting property trees to entirely replace UpdateDrawProperties on the main thread. Committed: https://crrev.com/e7fba1549e8bd030735e8f5b2269f69787c94f08 Cr-Commit-Position: refs/heads/master@{#314918}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M cc/trees/draw_property_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/property_tree_builder.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
enne (OOO)
5 years, 10 months ago (2015-02-05 22:48:38 UTC) #2
Ian Vollick
On 2015/02/05 22:48:38, enne wrote: cool. lgtm.
5 years, 10 months ago (2015-02-05 22:51:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897373002/1
5 years, 10 months ago (2015-02-05 23:01:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 23:58:18 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 00:00:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e7fba1549e8bd030735e8f5b2269f69787c94f08
Cr-Commit-Position: refs/heads/master@{#314918}

Powered by Google App Engine
This is Rietveld 408576698