Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 897363002: NaCl: Clean up to use the public API for creating validation-cacheable descs (Closed)

Created:
5 years, 10 months ago by Mark Seaborn
Modified:
5 years, 10 months ago
Reviewers:
teravest
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl: Clean up to use the public API for creating validation-cacheable descs Use the API that's defined in native_client/src/public/. That is already used by nacl_listener.cc, but the code in nacl_ipc_adapter.cc was written earlier, before the API in public/ was added. NaClDescCreateWithFilePathMetadata() does the same as the code we're replacing here. BUG=https://code.google.com/p/nativeclient/issues/detail?id=4073 TEST=browser_tests Committed: https://crrev.com/88df492682b84068023909c4ce90cd69e246c364 Cr-Commit-Position: refs/heads/master@{#315049}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -24 lines) Patch
M components/nacl/loader/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl/loader/nacl_ipc_adapter.cc View 3 chunks +4 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mark Seaborn
5 years, 10 months ago (2015-02-06 16:05:16 UTC) #2
teravest
lgtm
5 years, 10 months ago (2015-02-06 16:07:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897363002/1
5 years, 10 months ago (2015-02-06 16:10:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 16:51:43 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 16:52:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88df492682b84068023909c4ce90cd69e246c364
Cr-Commit-Position: refs/heads/master@{#315049}

Powered by Google App Engine
This is Rietveld 408576698