Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Issue 897353002: NaCl cleanup: Remove unneeded definition of ResolveFileToken() (Closed)

Created:
5 years, 10 months ago by Mark Seaborn
Modified:
5 years, 10 months ago
Reviewers:
teravest
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl cleanup: Remove unneeded definition of ResolveFileToken() This will allow the ResolveFileToken field to be removed from NaClValidationCache on the NaCl side. Chromium no longer uses the NaCl side's ability to call back to ResolveFileToken(). File tokens are handled entirely on the Chromium side. Removing this is safe because the NaCl side doesn't call ResolveFileToken() if the NaClDesc doesn't have a file token associated with it, or if ResolveFileToken is NULL (and we're setting it to NULL using memset()). BUG=https://code.google.com/p/nativeclient/issues/detail?id=4073 TEST=browser_tests Committed: https://crrev.com/747672ddb715596eade73524aa18a75aec236af0 Cr-Commit-Position: refs/heads/master@{#315050}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -32 lines) Patch
M components/nacl/loader/nacl_validation_query.h View 2 chunks +0 lines, -4 lines 0 comments Download
M components/nacl/loader/nacl_validation_query.cc View 3 chunks +0 lines, -28 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mark Seaborn
5 years, 10 months ago (2015-02-06 16:36:24 UTC) #2
teravest
lgtm
5 years, 10 months ago (2015-02-06 16:53:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897353002/1
5 years, 10 months ago (2015-02-06 17:06:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 17:09:09 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 17:09:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/747672ddb715596eade73524aa18a75aec236af0
Cr-Commit-Position: refs/heads/master@{#315050}

Powered by Google App Engine
This is Rietveld 408576698