Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 897313002: Refactor alternate protocol dictionary parsing. (Closed)

Created:
5 years, 10 months ago by Bence
Modified:
5 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor alternate protocol dictionary parsing. This CL breaks out into its own function the parsing of a DictionaryValue to AlternateProtocolInfo. This is only called once now, but as soon as we start storing multiple entries per server, we'll need to call it multiple times. See https://codereview.chromium.org/665083009/#ps460001. BUG=392575 Committed: https://crrev.com/54e76ef7eff2dae72dbac1c0f7c39aad467a9838 Cr-Commit-Position: refs/heads/master@{#314890}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase and use name constants. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -30 lines) Patch
M net/http/http_server_properties_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/http/http_server_properties_manager.cc View 1 1 chunk +43 lines, -30 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Bence
Ryan, PTAL. Thanks.
5 years, 10 months ago (2015-02-05 18:53:35 UTC) #2
Ryan Hamilton
lgtm looks good, but it needs a rebase. https://codereview.chromium.org/897313002/diff/1/net/http/http_server_properties_manager.cc File net/http/http_server_properties_manager.cc (right): https://codereview.chromium.org/897313002/diff/1/net/http/http_server_properties_manager.cc#newcode458 net/http/http_server_properties_manager.cc:458: if ...
5 years, 10 months ago (2015-02-05 19:11:15 UTC) #3
Ryan Hamilton
lgtm
5 years, 10 months ago (2015-02-05 20:02:31 UTC) #5
Ryan Hamilton
lgtm lgtm
5 years, 10 months ago (2015-02-05 20:02:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897313002/20001
5 years, 10 months ago (2015-02-05 21:02:45 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-05 21:58:26 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 22:00:14 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/54e76ef7eff2dae72dbac1c0f7c39aad467a9838
Cr-Commit-Position: refs/heads/master@{#314890}

Powered by Google App Engine
This is Rietveld 408576698