Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 8973: Unescape and use the filename when we have no title to display for a given en... (Closed)

Created:
12 years, 1 month ago by Glen Murphy
Modified:
9 years, 5 months ago
Reviewers:
ananta
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Unescape and use the filename when we have no title to display for a given entry (instead of displaying the whole path). This unifies the display of titles for local and remote files. For anyone watching, this is how tab titles will change: 'http://blah.com/index.html' will be 'index.html' 'http://blah.com/meat%20pie.pdf' will be 'meat pie.pdf' 'file://C:/blah/blue%20cheese.txt' will be 'blue cheese.txt' (previously this sometimes changed between the URL and blue%20cheese.txt depending on how the file was opened). BUG=2529, 2375 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4382

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M chrome/browser/navigation_controller.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/navigation_entry.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/navigation_entry.cc View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Glen Murphy
12 years, 1 month ago (2008-10-31 20:27:25 UTC) #1
ananta
The current implementation mimics Safari. I think it might be confusing to the user if ...
12 years, 1 month ago (2008-10-31 21:05:27 UTC) #2
Glen Murphy
12 years, 1 month ago (2008-10-31 21:17:36 UTC) #3
On 2008/10/31 21:05:27, ananta wrote:
> The current implementation mimics Safari. I think it might be confusing
> to the user if we just display the file component of an HTTP URL in case 
> of a missing title. For e.g. gallup.com would show up as index.aspx.
> 
> Would it be possible to display the filename for file based schemes?

I think showing the full URL for non-HTML remote resources is wrong (that is, if
you're looking at a PDF or image, you should be shown the filename). I guess
what we want is:
* URL for remote HTML content.
* Filename for all local content, and all non-HTML remote content (e.g. PDF /
TXT / Image).

Will investigate.

Powered by Google App Engine
This is Rietveld 408576698