Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 897263002: Fix HConstant(double, ...) constructor (Closed)

Created:
5 years, 10 months ago by Jakob Kummerow
Modified:
5 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix HConstant(double, ...) constructor It must always populate int32_value_, even if that's lossy, because other code (specifically, constant folding for truncating operations) relies on it. BUG=v8:3865 LOG=y Committed: https://crrev.com/bfe7f4af141da71aefd3af5b0733d1cb27281cf6 Cr-Commit-Position: refs/heads/master@{#26453}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M src/hydrogen-instructions.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-3865.js View 1 chunk +5 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jakob Kummerow
From class HConstant in hydrogen-instructions.h: int32_t NumberValueAsInteger32() const { DCHECK(HasNumberValue()); // Irrespective of whether a ...
5 years, 10 months ago (2015-02-05 10:03:23 UTC) #3
Benedikt Meurer
lgtm
5 years, 10 months ago (2015-02-05 10:05:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897263002/20001
5 years, 10 months ago (2015-02-05 10:05:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 10 months ago (2015-02-05 10:28:11 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 10:28:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bfe7f4af141da71aefd3af5b0733d1cb27281cf6
Cr-Commit-Position: refs/heads/master@{#26453}

Powered by Google App Engine
This is Rietveld 408576698