Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2455)

Unified Diff: mojo/public/bindings/js/handle.h

Issue 89723002: Convert the rest of the functions in core.cc to use CreateFunctionTemplate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase+comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/bindings/js/core.cc ('k') | mojo/public/bindings/js/handle.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/bindings/js/handle.h
diff --git a/mojo/public/bindings/js/handle.h b/mojo/public/bindings/js/handle.h
index 5e6af4b0fb312f712656e1b539678bac46297da7..4f3f6158e6e7b0884ca76e0c3b50a63fcedf07da 100644
--- a/mojo/public/bindings/js/handle.h
+++ b/mojo/public/bindings/js/handle.h
@@ -14,7 +14,7 @@ template<>
struct Converter<mojo::Handle> {
static v8::Handle<v8::Value> ToV8(v8::Isolate* isolate,
const mojo::Handle& val);
- static bool FromV8(v8::Handle<v8::Value> val,
+ static bool FromV8(v8::Isolate* isolate, v8::Handle<v8::Value> val,
mojo::Handle* out);
};
« no previous file with comments | « mojo/public/bindings/js/core.cc ('k') | mojo/public/bindings/js/handle.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698