Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: gin/wrappable_unittest.cc

Issue 89723002: Convert the rest of the functions in core.cc to use CreateFunctionTemplate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: realized didn't need changes to ArrayBuffer::Private Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gin/wrappable_unittest.cc
diff --git a/gin/wrappable_unittest.cc b/gin/wrappable_unittest.cc
index 7699fd1a12bcef96fa2d6c2ff8769cd5b413d598..da57cc32e6795c80ee0dd27ba693d65bff2680a3 100644
--- a/gin/wrappable_unittest.cc
+++ b/gin/wrappable_unittest.cc
@@ -98,7 +98,7 @@ TEST_F(WrappableTest, WrapAndUnwrap) {
EXPECT_FALSE(wrapper.IsEmpty());
MyObject* unwrapped = 0;
- EXPECT_TRUE(ConvertFromV8(wrapper, &unwrapped));
+ EXPECT_TRUE(ConvertFromV8(isolate, wrapper, &unwrapped));
EXPECT_EQ(obj, unwrapped);
}
@@ -124,7 +124,7 @@ TEST_F(WrappableTest, GetAndSetProperty) {
v8::Handle<v8::Value> val = script->Run();
EXPECT_FALSE(val.IsEmpty());
v8::Handle<v8::Function> func;
- EXPECT_TRUE(ConvertFromV8(val, &func));
+ EXPECT_TRUE(ConvertFromV8(isolate, val, &func));
v8::Handle<v8::Value> argv[] = {
ConvertToV8(isolate, obj.get()),
};

Powered by Google App Engine
This is Rietveld 408576698