Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: gin/wrappable.h

Issue 89723002: Convert the rest of the functions in core.cc to use CreateFunctionTemplate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: realized didn't need changes to ArrayBuffer::Private Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gin/wrappable.h
diff --git a/gin/wrappable.h b/gin/wrappable.h
index 79b71447f43eea973b8e5142972039e29bcd55cd..90fdbe2ad01bfcdbd821e4479fe09e738da0a522 100644
--- a/gin/wrappable.h
+++ b/gin/wrappable.h
@@ -38,7 +38,7 @@ template<>
struct Converter<Wrappable*> {
static v8::Handle<v8::Value> ToV8(v8::Isolate* isolate,
Wrappable* val);
- static bool FromV8(v8::Handle<v8::Value> val,
+ static bool FromV8(v8::Isolate* isolate, v8::Handle<v8::Value> val,
Wrappable** out);
};
@@ -47,9 +47,9 @@ struct WrappableConverter {
static v8::Handle<v8::Value> ToV8(v8::Isolate* isolate, T* val) {
return Converter<Wrappable*>::ToV8(isolate, val);
}
- static bool FromV8(v8::Handle<v8::Value> val, T** out) {
+ static bool FromV8(v8::Isolate* isolate, v8::Handle<v8::Value> val, T** out) {
Wrappable* wrappable = 0;
- if (!Converter<Wrappable*>::FromV8(val, &wrappable)
+ if (!Converter<Wrappable*>::FromV8(isolate, val, &wrappable)
|| wrappable->GetWrapperInfo() != &T::kWrapperInfo)
return false;
*out = static_cast<T*>(wrappable);

Powered by Google App Engine
This is Rietveld 408576698