Convert the rest of the functions in core.cc to use CreateFunctionTemplate.

gin/modules/module_registry.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gin/modules/module_registry.h"
 
 #include <string>
 #include <vector>
 
 #include "base/logging.h"
@@ skipping 93 matching lines @@
 void ModuleRegistry::RegisterGlobals(Isolate* isolate,
                                      v8::Handle<ObjectTemplate> templ) {
   templ->Set(StringToSymbol(isolate, "define"), GetDefineTemplate(isolate));
 }
 
 ModuleRegistry* ModuleRegistry::From(v8::Handle<Context> context) {
   Isolate* isolate = context->GetIsolate();
   v8::Handle<String> key = GetHiddenValueKey(isolate);
   v8::Handle<Value> value = context->Global()->GetHiddenValue(key);
   v8::Handle<External> external;
-  if (value.IsEmpty() || !ConvertFromV8(value, &external)) {
+  if (value.IsEmpty() || !ConvertFromV8(isolate, value, &external)) {
     PerContextData* data = PerContextData::From(context);
     if (!data)
       return NULL;
     ModuleRegistry* registry = new ModuleRegistry(isolate);
     context->Global()->SetHiddenValue(key, External::New(isolate, registry));
     data->AddSupplement(scoped_ptr<ContextSupplement>(registry));
     return registry;
   }
   return static_cast<ModuleRegistry*>(external->Value());
 }
@@ skipping 49 matching lines @@
   std::vector<v8::Handle<Value> > argv(argc);
   for (uint32_t i = 0; i < argc; ++i) {
     v8::Handle<String> key = StringToSymbol(isolate, pending->dependencies[i]);
     DCHECK(modules->HasOwnProperty(key));
     argv[i] = modules->Get(key);
   }
 
   v8::Handle<Value> module = Local<Value>::New(isolate, pending->factory);
 
   v8::Handle<Function> factory;
-  if (ConvertFromV8(module, &factory)) {
+  if (ConvertFromV8(isolate, module, &factory)) {
     PerContextData* data = PerContextData::From(isolate->GetCurrentContext());
     Runner* runner = data->runner();
     module = runner->Call(factory, runner->global(), argc, argv.data());
     if (pending->id.empty())
-      ConvertFromV8(factory->GetScriptOrigin().ResourceName(), &pending->id);
+      ConvertFromV8(isolate, factory->GetScriptOrigin().ResourceName(),
+                    &pending->id);
   }
 
   RegisterModule(isolate, pending->id, module);
 }
 
 bool ModuleRegistry::AttemptToLoad(Isolate* isolate,
                                    scoped_ptr<PendingModule> pending) {
   if (!CheckDependencies(pending.get())) {
     pending_modules_.push_back(pending.release());
     return false;
@@ skipping 11 matching lines @@
     for (size_t i = 0; i < pending_modules.size(); ++i) {
       scoped_ptr<PendingModule> pending(pending_modules[i]);
       pending_modules[i] = NULL;
       if (AttemptToLoad(isolate, pending.Pass()))
         keep_trying = true;
     }
   }
 }
 
 }  // namespace gin