Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1307)

Issue 897223003: Update {virtual,override,final} to follow C++11 style in ui. (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
Reviewers:
sadrul
CC:
chromium-reviews, jdduke+watch_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style in ui. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 Committed: https://crrev.com/9ba5a2720fbb178289fe54abcb5a7082ac48fe6e Cr-Commit-Position: refs/heads/master@{#314967}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -63 lines) Patch
M ui/android/resources/resource_manager_impl_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/events/android/scroller.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/gfx/screen_android.cc View 2 chunks +11 lines, -15 lines 0 comments Download
M ui/gl/gl_context_android.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M ui/gl/gl_image_surface_texture.h View 1 chunk +15 lines, -15 lines 0 comments Download
M ui/native_theme/native_theme_android.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog_android.h View 1 chunk +12 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
5 years, 10 months ago (2015-02-06 01:10:31 UTC) #2
sadrul
lgtm
5 years, 10 months ago (2015-02-06 01:24:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897223003/1
5 years, 10 months ago (2015-02-06 01:26:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 03:46:11 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 03:48:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ba5a2720fbb178289fe54abcb5a7082ac48fe6e
Cr-Commit-Position: refs/heads/master@{#314967}

Powered by Google App Engine
This is Rietveld 408576698