Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: runtime/vm/service/vmservice.dart

Issue 897193002: Finish moving service protocol to json rpc. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/service/service.idl ('k') | runtime/vm/service_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service/vmservice.dart
diff --git a/runtime/vm/service/vmservice.dart b/runtime/vm/service/vmservice.dart
index 3c5ed243ff6a8cf1cc4dd9e79114ecbe9fef38ef..d4eca93ddb6b64c4580bf25cc0dc520b12e50445 100644
--- a/runtime/vm/service/vmservice.dart
+++ b/runtime/vm/service/vmservice.dart
@@ -138,18 +138,13 @@ class VMService extends MessageRouter {
if (message.completed) {
return message.response;
}
+ // TODO(turnidge): Update to json rpc. BEFORE SUBMIT.
if ((message.path.length == 1) && (message.path[0] == 'clients')) {
_clientCollection(message);
return message.response;
}
- if (message.isOld) {
- if (message.path[0] == 'isolates') {
- return runningIsolates.route(message);
- }
- } else {
- if (message.params['isolate'] != null) {
- return runningIsolates.route(message);
- }
+ if (message.params['isolateId'] != null) {
+ return runningIsolates.route(message);
}
return message.sendToVM();
}
« no previous file with comments | « runtime/vm/service/service.idl ('k') | runtime/vm/service_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698