Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1402)

Unified Diff: runtime/observatory/lib/src/elements/heap_map.dart

Issue 897193002: Finish moving service protocol to json rpc. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/heap_map.dart
diff --git a/runtime/observatory/lib/src/elements/heap_map.dart b/runtime/observatory/lib/src/elements/heap_map.dart
index 2e36c2dc40cbd87463bce9241b3f5fe3fcfac442..05ed60a9b407ff4cce330e72b7b5d6bcbbc839fd 100644
--- a/runtime/observatory/lib/src/elements/heap_map.dart
+++ b/runtime/observatory/lib/src/elements/heap_map.dart
@@ -96,7 +96,7 @@ class HeapMapElement extends ObservatoryElement {
}
void _updateClassList(classList, int freeClassId) {
- for (var member in classList['members']) {
+ for (var member in classList['classes']) {
if (member is! Class) {
// TODO(turnidge): The printing for some of these non-class
// members is broken. Fix this:
@@ -160,8 +160,13 @@ class HeapMapElement extends ObservatoryElement {
void _handleClick(MouseEvent event) {
var address = _objectAt(event.offset).address.toRadixString(16);
- app.locationManager.go(app.locationManager.makeLink(
- "${isolate.relativeLink('address/$address')}"));
+ isolate.getObjectByAddress(address).then((result) {
+ if (result is DartError) {
+ Logger.root.severe(result.message);
+ } else {
+ app.locationManager.go(gotoLink('/inspect', result));
+ }
+ });
}
void _updateFragmentationData() {
« no previous file with comments | « runtime/observatory/lib/src/elements/general_error.html ('k') | runtime/observatory/lib/src/elements/heap_map.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698