Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 897173004: Increase warning threshold for "super long" delayed tasks. (Closed)

Created:
5 years, 10 months ago by miu
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang, brucedawson
CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul, brucedawson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Increase warning threshold for "super long" delayed tasks. To reduce debug logging spam, this increases the warning threshold for posting "super long" delayed tasks to 14 days (was ~18 minutes before). Also, make the logging message more readable by printing values in terms of seconds rather than microseconds. BUG=450045 Committed: https://crrev.com/beed41d812e408cbda48236d5cdcc8418926717f Cr-Commit-Position: refs/heads/master@{#314778}

Patch Set 1 #

Patch Set 2 : Fix 'unused variable' compile error on release builds. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M base/message_loop/incoming_task_queue.cc View 1 2 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
miu
thestig: PTAL. Changes made as discussed in bug 450045.
5 years, 10 months ago (2015-02-05 05:31:40 UTC) #2
brucedawson
lgtm
5 years, 10 months ago (2015-02-05 05:40:15 UTC) #4
Lei Zhang
lgtm
5 years, 10 months ago (2015-02-05 06:13:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897173004/20001
5 years, 10 months ago (2015-02-05 09:11:49 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-05 09:15:13 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 09:16:08 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/beed41d812e408cbda48236d5cdcc8418926717f
Cr-Commit-Position: refs/heads/master@{#314778}

Powered by Google App Engine
This is Rietveld 408576698