Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1114)

Issue 897173003: Revert of Set defaultPageScaleLimits before setIgnoreViewportTagScaleLimits (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Set defaultPageScaleLimits before setIgnoreViewportTagScaleLimits (patchset #2 id:20001 of https://codereview.chromium.org/860283005/) Reason for revert: Speculatively reverting to try to fix broken layout tests in Blink: compositing/iframes/iframe-composited-scrolling-hide-and-show.html compositing/iframes/overlapped-iframe-iframe.html svg/as-border-image/svg-as-border-image-2.html and more. Original issue's description: > Set defaultPageScaleLimits before setIgnoreViewportTagScaleLimits > > setIgnoreViewportTagScaleLimits copies the default limits into the UA > constraints. This was happening before the defualt limits were set during > initialization so it was clamping page scale at [1,1]. > > BUG=453377 > > Committed: https://crrev.com/ebbcc53e21fbfe15a76fa7fbf6d14c84095880ee > Cr-Commit-Position: refs/heads/master@{#314668} TBR=aelias@chromium.org,sievers@chromium.org,bokan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=453377 Committed: https://crrev.com/910b93d89932cc75fcce36f4dbc5f3bef7c2f064 Cr-Commit-Position: refs/heads/master@{#314723}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M content/renderer/render_view_impl.cc View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dcheng
Created Revert of Set defaultPageScaleLimits before setIgnoreViewportTagScaleLimits
5 years, 10 months ago (2015-02-05 02:33:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897173003/1
5 years, 10 months ago (2015-02-05 02:34:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 02:35:57 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/910b93d89932cc75fcce36f4dbc5f3bef7c2f064 Cr-Commit-Position: refs/heads/master@{#314723}
5 years, 10 months ago (2015-02-05 02:37:07 UTC) #4
dcheng
The Mac 10.8 retina tests appear to still be broken, so I'll probably be reverting ...
5 years, 10 months ago (2015-02-05 03:14:20 UTC) #5
aelias_OOO_until_Jul13
On 2015/02/05 at 03:14:20, dcheng wrote: > The Mac 10.8 retina tests appear to still ...
5 years, 10 months ago (2015-02-05 03:39:27 UTC) #6
dcheng
5 years, 10 months ago (2015-02-05 04:02:43 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/900153002/ by dcheng@chromium.org.

The reason for reverting is: These aren't the changes you're looking for..

Powered by Google App Engine
This is Rietveld 408576698