Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 897103002: Revert of Reland Ensure WebView notifies desktop automation on creation, destruction, and change (Closed)

Created:
5 years, 10 months ago by ccameron
Modified:
5 years, 10 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, extensions-reviews_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland Ensure WebView notifies desktop automation on creation, destruction, and change (patchset #5 id:80001 of https://codereview.chromium.org/895623003/) Reason for revert: Seeing intermittent failures on vox tests after this patch https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/55807 BackgroundTest.InitialFeedback BackgroundTest.ContinuousRead BackgroundTest.CaretNavigation Original issue's description: > Reland Ensure WebView notifies desktop automation on creation, destruction, and change > > Original issue https://codereview.chromium.org/880063002 > > TBR=dtseng@chromium.org > > Committed: https://crrev.com/4a61275d7b2708d4aca1e1c4975739424a379fc3 > Cr-Commit-Position: refs/heads/master@{#314378} TBR=dtseng@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/50ed7018d4042c5aadf783869206ca996472c816 Cr-Commit-Position: refs/heads/master@{#314630}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -127 lines) Patch
M chrome/browser/resources/chromeos/chromevox/common/chrome_extension_externs.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/editable_text_base.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js View 3 chunks +0 lines, -21 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 5 chunks +52 lines, -33 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs View 2 chunks +20 lines, -19 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js View 1 chunk +1 line, -8 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/testing/mock_tts.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/automation/automation_node.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/extension_js_browser_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/extension_load_waiter_one_shot.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/views/accessibility/ax_aura_obj_cache.h View 2 chunks +0 lines, -6 lines 0 comments Download
M ui/views/accessibility/ax_aura_obj_cache.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/accessibility/ax_widget_obj_wrapper.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M ui/views/controls/webview/webview.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/webview/webview.cc View 7 chunks +12 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ccameron
Created Revert of Reland Ensure WebView notifies desktop automation on creation, destruction, and change
5 years, 10 months ago (2015-02-04 21:00:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897103002/1
5 years, 10 months ago (2015-02-04 21:02:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 21:03:25 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 21:04:34 UTC) #4
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/50ed7018d4042c5aadf783869206ca996472c816
Cr-Commit-Position: refs/heads/master@{#314630}

Powered by Google App Engine
This is Rietveld 408576698