Issue 897093004: Pepper: Make Mojo test more strict.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 897093004: Pepper: Make Mojo test more strict. (Closed)

Created:
5 years, 10 months ago by teravest

Modified:
5 years, 10 months ago

Reviewers:
dmichael (off chromium)

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, Nick Bray (chromium)

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Pepper: Make Mojo test more strict. Mojo's MessagePipe constructor uses assert() to check that MojoCreateMessagePipe returns OK. This change makes the test explicitly check the return value of MojoCreateMessagePipe, giving more correct test behavior for Release builds. Committed: https://crrev.com/fd9487174ee153cf5f741787bab238d256f2d2e0 Cr-Commit-Position: refs/heads/master@{#315168}

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	ppapi/tests/mojo/test_mojo.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897093004/1

5 years, 10 months ago (2015-02-07 01:38:49 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-07 02:47:20 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/fd9487174ee153cf5f741787bab238d256f2d2e0
Cr-Commit-Position: refs/heads/master@{#315168}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages