Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 897083003: Call InstallTracker::RemoveObserver when StartupAppLauncher is destroyed (Closed)

Created:
5 years, 10 months ago by hashimoto
Modified:
5 years, 10 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call InstallTracker::RemoveObserver when StartupAppLauncher is destroyed BUG=456042 Committed: https://crrev.com/03c6092634d353ebcc0733d84e4b0378b5708dd1 Cr-Commit-Position: refs/heads/master@{#315172}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/chromeos/app_mode/startup_app_launcher.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
hashimoto
Could you review this?
5 years, 10 months ago (2015-02-06 10:47:31 UTC) #2
xiyuan
lgtm
5 years, 10 months ago (2015-02-06 15:15:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897083003/1
5 years, 10 months ago (2015-02-07 03:20:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-07 03:24:00 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-07 03:25:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03c6092634d353ebcc0733d84e4b0378b5708dd1
Cr-Commit-Position: refs/heads/master@{#315172}

Powered by Google App Engine
This is Rietveld 408576698