Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 897023003: Rewrite fast/multicol/overflow-across-columns.html as a reftest. (Closed)

Created:
5 years, 10 months ago by mstensho (USE GERRIT)
Modified:
5 years, 10 months ago
Reviewers:
andersr
CC:
blink-reviews, mstensho (USE GERRIT)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rewrite fast/multicol/overflow-across-columns.html as a reftest. Removed fast/multicol/overflow-across-columns-percent-height.html , since it was pretty useless. A percentage max-height inside something auto height is going to resolve to 'none'. BUG=386567 R=andersr@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189783

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -340 lines) Patch
M LayoutTests/TestExpectations View 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/overflow-across-columns.html View 1 chunk +10 lines, -24 lines 0 comments Download
A LayoutTests/fast/multicol/overflow-across-columns-expected.html View 1 chunk +7 lines, -0 lines 0 comments Download
D LayoutTests/fast/multicol/overflow-across-columns-percent-height.html View 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/platform/linux/fast/multicol/overflow-across-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/multicol/overflow-across-columns-percent-height-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/overflow-across-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/overflow-across-columns-expected.txt View 1 chunk +0 lines, -71 lines 0 comments Download
D LayoutTests/platform/mac/fast/multicol/overflow-across-columns-percent-height-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/overflow-across-columns-percent-height-expected.txt View 1 chunk +0 lines, -72 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/overflow-across-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/overflow-across-columns-expected.txt View 1 chunk +0 lines, -70 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/overflow-across-columns-percent-height-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/overflow-across-columns-percent-height-expected.txt View 1 chunk +0 lines, -71 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 10 months ago (2015-02-04 19:44:00 UTC) #1
andersr
lgtm
5 years, 10 months ago (2015-02-09 06:56:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897023003/1
5 years, 10 months ago (2015-02-09 07:03:05 UTC) #4
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 07:05:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189783

Powered by Google App Engine
This is Rietveld 408576698