tests/language/cyclic_type_test.dart - Issue 897013003: dart2js: add common names to mangledGlobalNames in new emitter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/language/cyclic_type_test.dart

Issue 897013003: dart2js: add common names to mangledGlobalNames in new emitter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed comments. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart ('k') | tests/language/f_bounded_quantification5_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/language/cyclic_type_test.dart

diff --git a/tests/language/cyclic_type_test.dart b/tests/language/cyclic_type_test.dart

index 4de75d947c24dd9de6d51d4204f690254784f204..a3e93f52186c6ebeced165ef0e22d90e40540b1f 100644

--- a/tests/language/cyclic_type_test.dart

+++ b/tests/language/cyclic_type_test.dart

@@ -28,6 +28,11 @@ class Derived1<U> extends Base<Derived2<U>> {} /// 04: ok

class Derived2<V> extends Base<Derived1<Derived2<V>>> {} /// 04: ok

main() {

+ // In the tests below we test that we get "int" when calling toString() on the

floitsch 2015/02/05 10:55:35 (same is true for "bool")

zarah 2015/02/06 08:53:12 Done.

+ // int type. This is not required behaviour. However, we want to keep the

floitsch 2015/02/05 10:55:35 tiny tiny nit: behavior. (we generally use US engl

zarah 2015/02/06 08:53:12 Done.

+ // original names for the most common core types so we make sure to handle

+ // these specifically in the compiler.

var d;

d = new Derived(); /// 00: continued

Expect.equals("Derived", d.t.toString()); /// 00: continued

@@ -37,6 +42,7 @@ main() {

Expect.equals("Derived<Derived>", d.t.toString()); /// 00: continued

d = new Derived(); /// 01: continued

Expect.equals("Derived<Derived<int>>", d.t.toString()); /// 01: continued

d = new Derived<bool>(); /// 01: continued

Expect.equals("Derived<Derived<int>>", d.t.toString()); /// 01: continued