dart2js: add common names to mangledGlobalNames in new emitter.

pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.new_js_emitter.model_emitter;
 
 import '../../dart2jslib.dart' show Compiler;
 import '../../dart_types.dart' show DartType;
 import '../../js/js.dart' as js;
 import '../../js_backend/js_backend.dart' show
@@ skipping 191 matching lines @@
       globals.addAll(emitLoadUrisAndHashes(program.loadMap));
       globals.add(emitIsHunkLoadedFunction());
       globals.add(emitInitializeLoadedHunk());
     }
 
     if (program.typeToInterceptorMap != null) {
       globals.add(new js.Property(js.string(TYPE_TO_INTERCEPTOR_MAP),
                                   program.typeToInterceptorMap));
     }
 
-    globals.add(new js.Property(js.string(MANGLED_GLOBAL_NAMES),
-                                js.js('Object.create(null)', [])));
+    globals.add(emitMangledGlobalNames());
 
     globals.add(emitGetTypeFromName());
 
     globals.add(emitMetadata(program));
 
     if (program.outputContainsNativeClasses) {
       globals.add(new js.Property(js.string(INTERCEPTORS_BY_TAG),
                                   js.js('Object.create(null)', [])));
       globals.add(new js.Property(js.string(LEAF_TAGS),
                                   js.js('Object.create(null)', [])));
     }
 
     js.ObjectInitializer globalsObject = new js.ObjectInitializer(globals);
 
     List<js.Statement> statements =
         [new js.ExpressionStatement(
             new js.VariableDeclarationList(
                 [new js.VariableInitialization(
                     new js.VariableDeclaration("init", allowRename: false),
                     globalsObject)]))];
     return new js.Block(statements);
   }
 
+  js.Property emitMangledGlobalNames() {
+    List<js.Property> names = <js.Property>[];
+    [compiler.intClass, compiler.doubleClass, compiler.numClass,

[floitsch, 2015/02/04 16:18:28]

Add comment why this is needed/wanted.

Update the test that failed and explain that this is not required but wanted
behavior.

[zarah, 2015/02/06 08:53:11]

Done.

+    compiler.stringClass, compiler.boolClass, compiler.nullClass,

[floitsch, 2015/02/04 16:18:28]

indent by 1.

[zarah, 2015/02/06 08:53:11]

Done.

+    compiler.listClass].forEach((cls) =>

[floitsch, 2015/02/04 16:18:28]

Don't use "cls". "Cls" is only used for "Class" instances. ClassElements are
always called element or classElement.

[floitsch, 2015/02/04 16:18:28]

Split it into smaller pieces.
List<ClassElement> nativeClassesNeedingUnmangledName =
  [compiler.stringClass, ...];

nativeClassesNeedingUnmangledName.forEach(...)

[floitsch, 2015/02/04 16:18:28]

make this a "{}" function body.

[zarah, 2015/02/06 08:53:11]

Done.

[zarah, 2015/02/06 08:53:11]

Done.

[zarah, 2015/02/06 08:53:12]

Done.

+        names.add(new js.Property(js.string(namer.getNameOfClass(cls)),
+                                  js.string(cls.name))));
+
+    return new js.Property(js.string(MANGLED_GLOBAL_NAMES),
+                           new js.ObjectInitializer(names, isOneLiner: false));

[floitsch, 2015/02/04 16:18:28]

I would have kept it as a one-liner.

[zarah, 2015/02/06 08:53:11]

Done.

+  }
+
   List<js.Property> emitLoadUrisAndHashes(Map<String, List<Fragment>> loadMap) {
     js.ArrayInitializer outputUris(List<Fragment> fragments) {
       return js.stringArray(fragments.map((DeferredFragment fragment) =>
           "${fragment.outputFileName}$deferredExtension"));
     }
     js.ArrayInitializer outputHashes(List<Fragment> fragments) {
       // TODO(floitsch): the hash must depend on the generated code.
       return js.numArray(
           fragments.map((DeferredFragment fragment) => fragment.hashCode));
     }
@@ skipping 640 matching lines @@
 
   var end = Date.now();
   print('Setup: ' + (end - start) + ' ms.');
 
   #main();  // Start main.
 
 }(Date.now(), #code)
 }""";
 
 }