chrome/browser/autocomplete/history_url_provider.cc - Issue 896983003: Componentize ScoredHistoryMatch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/history_url_provider.cc

Issue 896983003: Componentize ScoredHistoryMatch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use base::saturated_cast<> to convert from float to int Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/autocomplete/history_url_provider.cc

diff --git a/chrome/browser/autocomplete/history_url_provider.cc b/chrome/browser/autocomplete/history_url_provider.cc

index 5614b6fb7bec6ba033b10997815c00755cd0a14a..ae6fba03d380efa3ec89ebeb2f55e6e31253874b 100644

--- a/chrome/browser/autocomplete/history_url_provider.cc

+++ b/chrome/browser/autocomplete/history_url_provider.cc

@@ -16,10 +16,10 @@

#include "base/strings/utf_string_conversions.h"

#include "base/time/time.h"

#include "chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.h"

+#include "chrome/browser/autocomplete/scored_history_match_builder_impl.h"

#include "chrome/browser/history/history_backend.h"

#include "chrome/browser/history/history_service.h"

#include "chrome/browser/history/history_service_factory.h"

-#include "chrome/browser/history/scored_history_match.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/search_engines/template_url_service_factory.h"

#include "chrome/browser/search_engines/ui_thread_search_terms_data.h"

@@ -714,7 +714,7 @@ ACMatchClassifications HistoryURLProvider::ClassifyDescription(

// are guaranteed that the beginning of input_text must be a word break.

history::WordStarts offsets(1, 0u);

description_matches =

- history::ScoredHistoryMatch::FilterTermMatchesByWordStarts(

+ ScoredHistoryMatchBuilderImpl::FilterTermMatchesByWordStarts(

description_matches, offsets, description_word_starts, 0,

std::string::npos);

return SpansFromTermMatch(