OLD | NEW |
1 include_rules = [ | 1 include_rules = [ |
2 # History is being made into a Browser Component (http://crbug.com/370850), so | 2 # History is being made into a Browser Component (http://crbug.com/370850), so |
3 # we have these basic rules followed by temporary exceptions. Please don't | 3 # we have these basic rules followed by temporary exceptions. Please don't |
4 # add to the list of exceptions! | 4 # add to the list of exceptions! |
5 # | 5 # |
6 # Please send reviews to sdefresne@chromium.org when adding dependencies to | 6 # Please send reviews to sdefresne@chromium.org when adding dependencies to |
7 # this list. | 7 # this list. |
8 "-chrome/browser", | 8 "-chrome/browser", |
9 "-components", | 9 "-components", |
10 | 10 |
11 "+chrome/browser/history", | 11 "+chrome/browser/history", |
12 "+components/history", | 12 "+components/history", |
13 "+components/favicon_base", | 13 "+components/favicon_base", |
14 "+components/keyed_service/core", | 14 "+components/keyed_service/core", |
15 "+components/signin/core/browser", | 15 "+components/signin/core/browser", |
16 | 16 |
17 # TODO(sdefresne): Bring this list to zero. | 17 # TODO(sdefresne): Bring this list to zero. |
18 # | 18 # |
19 # Do not add to the list of temporarily-allowed dependencies below, | 19 # Do not add to the list of temporarily-allowed dependencies below, |
20 # and please do not introduce more #includes of these files. | 20 # and please do not introduce more #includes of these files. |
21 "!chrome/browser/autocomplete/history_url_provider.h", | |
22 "!chrome/browser/chrome_notification_types.h", | 21 "!chrome/browser/chrome_notification_types.h", |
23 "!chrome/browser/prerender/prerender_contents.h", | 22 "!chrome/browser/prerender/prerender_contents.h", |
24 "!chrome/browser/prerender/prerender_manager.h", | 23 "!chrome/browser/prerender/prerender_manager.h", |
25 "!chrome/browser/prerender/prerender_manager_factory.h", | 24 "!chrome/browser/prerender/prerender_manager_factory.h", |
26 "!chrome/browser/profiles/incognito_helpers.h", | 25 "!chrome/browser/profiles/incognito_helpers.h", |
27 "!chrome/browser/profiles/profile.h", | 26 "!chrome/browser/profiles/profile.h", |
28 "!chrome/browser/profiles/profile_manager.h", | 27 "!chrome/browser/profiles/profile_manager.h", |
29 "!chrome/browser/signin/profile_oauth2_token_service_factory.h", | 28 "!chrome/browser/signin/profile_oauth2_token_service_factory.h", |
30 "!chrome/browser/signin/signin_manager_factory.h", | 29 "!chrome/browser/signin/signin_manager_factory.h", |
31 "!chrome/browser/ui/browser.h", | 30 "!chrome/browser/ui/browser.h", |
32 "!chrome/browser/ui/browser_finder.h", | 31 "!chrome/browser/ui/browser_finder.h", |
33 "!components/bookmarks/browser/bookmark_utils.h", | 32 "!components/bookmarks/browser/bookmark_utils.h", |
34 "!components/dom_distiller/core/url_constants.h", | 33 "!components/dom_distiller/core/url_constants.h", |
35 "!components/omnibox/omnibox_field_trial.h", | |
36 "!components/omnibox/url_prefix.h", | |
37 "!components/visitedlink/browser/visitedlink_delegate.h", | 34 "!components/visitedlink/browser/visitedlink_delegate.h", |
38 "!components/visitedlink/browser/visitedlink_master.h", | 35 "!components/visitedlink/browser/visitedlink_master.h", |
39 ] | 36 ] |
40 | 37 |
41 specific_include_rules = { | 38 specific_include_rules = { |
42 # Browser tests, by definition, need access to the browser objects. | 39 # Browser tests, by definition, need access to the browser objects. |
43 '.*_(api|browser|)test\.cc': [ | 40 '.*_(api|browser|)test\.cc': [ |
44 "+chrome/browser", | 41 "+chrome/browser", |
45 ], | 42 ], |
46 # chrome_.* and .*_factory won't be componentized as they belong to the | 43 # chrome_.* and .*_factory won't be componentized as they belong to the |
47 # embedder, so they can depend on other feature in chrome/. Same thing | 44 # embedder, so they can depend on other feature in chrome/. Same thing |
48 # for android specific code. | 45 # for android specific code. |
49 '(chrome_.*|.*_factory)\.(cc|h)': [ | 46 '(chrome_.*|.*_factory)\.(cc|h)': [ |
50 "+chrome/browser/bookmarks/bookmark_model_factory.h", | 47 "+chrome/browser/bookmarks/bookmark_model_factory.h", |
51 "+chrome/browser/bookmarks/chrome_bookmark_client.h", | 48 "+chrome/browser/bookmarks/chrome_bookmark_client.h", |
52 "+chrome/browser/bookmarks/chrome_bookmark_client_factory.h", | 49 "+chrome/browser/bookmarks/chrome_bookmark_client_factory.h", |
53 "+chrome/browser/content_settings/cookie_settings.h", | 50 "+chrome/browser/content_settings/cookie_settings.h", |
54 "+chrome/browser/sync/profile_sync_service.h", | 51 "+chrome/browser/sync/profile_sync_service.h", |
55 "+chrome/browser/sync/profile_sync_service_factory.h", | 52 "+chrome/browser/sync/profile_sync_service_factory.h", |
56 "+chrome/browser/ui/profile_error_dialog.h", | 53 "+chrome/browser/ui/profile_error_dialog.h", |
57 "+components/bookmarks/browser", | 54 "+components/bookmarks/browser", |
58 "+components/keyed_service/content", | 55 "+components/keyed_service/content", |
59 ], | 56 ], |
60 # TODO(sdefresne): Bring this list to zero. | 57 # TODO(sdefresne): Bring this list to zero. |
61 # | 58 # |
62 # Do not add to the list of temporarily-allowed dependencies below, | 59 # Do not add to the list of temporarily-allowed dependencies below, |
63 # and please do not introduce more #includes of these files. | 60 # and please do not introduce more #includes of these files. |
64 '.*_[a-z]*test\.cc': [ | 61 '.*_[a-z]*test\.cc': [ |
65 "!chrome/browser/autocomplete/scored_history_match_builder.h", | 62 "!chrome/browser/autocomplete/scored_history_match_builder_impl.h", |
66 "!chrome/browser/bookmarks/bookmark_model_factory.h", | 63 "!chrome/browser/bookmarks/bookmark_model_factory.h", |
67 "!chrome/browser/sync/profile_sync_service.h", | 64 "!chrome/browser/sync/profile_sync_service.h", |
68 "!chrome/browser/sync/profile_sync_service_factory.h", | 65 "!chrome/browser/sync/profile_sync_service_factory.h", |
69 "!chrome/browser/sync/profile_sync_service_mock.h", | 66 "!chrome/browser/sync/profile_sync_service_mock.h", |
70 "!components/bookmarks/test/bookmark_test_helpers.h", | 67 "!components/bookmarks/test/bookmark_test_helpers.h", |
71 ] | 68 ] |
72 } | 69 } |
OLD | NEW |