Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 896983002: [turbofan] Make ContextScope a proper encapsulation of the current context. (Closed)

Created:
5 years, 10 months ago by titzer
Modified:
5 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Make ContextScope a proper encapsulation of the current context. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/d923864c79b1ca12a3f7a463531a64f7fdf0c59e Cr-Commit-Position: refs/heads/master@{#26421}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -27 lines) Patch
M src/compiler/ast-graph-builder.h View 3 chunks +1 line, -5 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 9 chunks +25 lines, -22 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
titzer
5 years, 10 months ago (2015-02-04 09:23:27 UTC) #1
Michael Starzinger
LGTM. I like it. https://codereview.chromium.org/896983002/diff/1/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc (right): https://codereview.chromium.org/896983002/diff/1/src/compiler/ast-graph-builder.cc#newcode144 src/compiler/ast-graph-builder.cc:144: next_(builder->execution_control()), nit: While you are ...
5 years, 10 months ago (2015-02-04 09:34:35 UTC) #2
titzer
On 2015/02/04 09:34:35, Michael Starzinger wrote: > LGTM. I like it. > > https://codereview.chromium.org/896983002/diff/1/src/compiler/ast-graph-builder.cc > ...
5 years, 10 months ago (2015-02-04 09:38:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896983002/20001
5 years, 10 months ago (2015-02-04 09:39:25 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-04 09:59:54 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 10:00:09 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d923864c79b1ca12a3f7a463531a64f7fdf0c59e
Cr-Commit-Position: refs/heads/master@{#26421}

Powered by Google App Engine
This is Rietveld 408576698