Use UIThreadSearchTermsData to get the Google base URL.

Use UIThreadSearchTermsData to get the Google base URL.

This simplifies the code some by eliminating google_profile_helper entirely, and
ensures that everyone who is trying to construct a "search URL" will correctly
respect things like the command-line Google base URL override switch.

This also moves some related code from URLRequestMockHTTPJob into its lone
caller and stops assuming that the search URL scheme is always HTTP.

BUG=364183
TEST=none

Committed: https://crrev.com/de91a933871266ff51441f8030b793ddec8c8d68
Cr-Commit-Position: refs/heads/master@{#314600}

[Peter Kasting, 2015-02-04 03:48:33]

pkasting@chromium.org changed reviewers:
+ mmenke@chromium.org, sky@chromium.org

[Peter Kasting, 2015-02-04 03:48:34]

sky: chrome/
mmenke: net/ (only removing code, yay!)

[mmenke, 2015-02-04 03:53:23]

On 2015/02/04 03:48:34, Peter Kasting wrote:
> sky: chrome/
> mmenke: net/ (only removing code, yay!)

net/ LGTM.  I love seeing code deleted.  :)

[sky, 2015-02-04 18:02:24]

LGTM

That said, I tend to think it isn't intuitive that UIThreadSearchTermsData is
the place you go to for getting the base url. I would think a function named
GetGoogleBaseURL(Profile*) by itself, in it's own file, that uses
UIThreadSearchTermsData would be more discoverable.

[Peter Kasting, 2015-02-04 19:03:02]

On 2015/02/04 18:02:24, sky wrote:
> LGTM
> 
> That said, I tend to think it isn't intuitive that UIThreadSearchTermsData is
> the place you go to for getting the base url. I would think a function named
> GetGoogleBaseURL(Profile*) by itself, in it's own file, that uses
> UIThreadSearchTermsData would be more discoverable.

I agree it would be more obvious.  I'm just loathe to have a pair of files with
all the license boilerplate and such whose sole purpose to to provide this:

  return UIThreadSearchTermsData(profile).GoogleBaseURLValue();

It would be OK if I could shove this into google_util.h with a bunch of other
related functions, but since that lives in components/, it can't know about
UIThreadSearchTermsData or Profile.  So I'd have to use something like the
existing google_profile_helper.h.  At that point it just feels like overhead to
me.  I dunno.

Maybe if a bunch more places want this, or we get other functions that should
also live in such a file, or the implementation becomes more complex, I can add
it.

[Peter Kasting, 2015-02-04 19:03:10]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2015-02-04 19:03:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/896943002/20001

[commit-bot: I haz the power, 2015-02-04 19:08:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-04 19:10:05]

Patchset 2 (id:??) landed as
https://crrev.com/de91a933871266ff51441f8030b793ddec8c8d68
Cr-Commit-Position: refs/heads/master@{#314600}