Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 89683003: Rename DesktopMediaPickerModel[Impl]->[Native]DesktopMediaList (Closed)

Created:
7 years ago by Sergey Ulanov
Modified:
7 years ago
Reviewers:
sky
CC:
chromium-reviews, extensions-reviews_chromium.org, fischman+watch_chromium.org, tfarina, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, chromium-apps-reviews_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Rename DesktopMediaPickerModel[Impl]->[Native]DesktopMediaList NativeDesktopMediaList provides list of native screens and windows. Another implementation of DesktopMediaList interface will be used for Ash screens and windows. BUG=295102 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238274

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 6

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+377 lines, -1126 lines) Patch
M chrome/browser/extensions/api/desktop_capture/desktop_capture_api.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc View 1 2 3 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc View 1 2 3 3 chunks +4 lines, -5 lines 0 comments Download
A chrome/browser/media/desktop_media_list.h View 1 2 3 1 chunk +60 lines, -0 lines 0 comments Download
A chrome/browser/media/desktop_media_list_observer.h View 1 2 3 4 5 6 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/media/desktop_media_picker.h View 2 chunks +3 lines, -3 lines 0 comments Download
D chrome/browser/media/desktop_media_picker_model.h View 1 chunk +0 lines, -157 lines 0 comments Download
D chrome/browser/media/desktop_media_picker_model.cc View 1 chunk +0 lines, -337 lines 0 comments Download
D chrome/browser/media/desktop_media_picker_model_unittest.cc View 1 chunk +0 lines, -443 lines 0 comments Download
M chrome/browser/media/desktop_streams_registry.h View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/media/native_desktop_media_list.h View 1 2 3 1 chunk +101 lines, -0 lines 0 comments Download
A + chrome/browser/media/native_desktop_media_list.cc View 1 2 3 13 chunks +38 lines, -39 lines 0 comments Download
A + chrome/browser/media/native_desktop_media_list_unittest.cc View 1 2 3 12 chunks +34 lines, -33 lines 0 comments Download
M chrome/browser/ui/cocoa/media_picker/desktop_media_picker_bridge.h View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/media_picker/desktop_media_picker_cocoa.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/media_picker/desktop_media_picker_cocoa.mm View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.h View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm View 1 2 3 5 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller_unittest.mm View 1 2 3 4 5 11 chunks +49 lines, -46 lines 0 comments Download
M chrome/browser/ui/cocoa/media_picker/desktop_media_picker_item.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/media_picker/desktop_media_picker_item.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/desktop_media_picker_views.cc View 1 2 3 11 chunks +22 lines, -21 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Sergey Ulanov
7 years ago (2013-11-27 00:38:40 UTC) #1
sky
https://codereview.chromium.org/89683003/diff/40001/chrome/browser/media/desktop_media_list.h File chrome/browser/media/desktop_media_list.h (right): https://codereview.chromium.org/89683003/diff/40001/chrome/browser/media/desktop_media_list.h#newcode23 chrome/browser/media/desktop_media_list.h:23: virtual ~Observer() {} Generally observers are not owned. To ...
7 years ago (2013-12-02 15:37:45 UTC) #2
Sergey Ulanov
https://codereview.chromium.org/89683003/diff/40001/chrome/browser/media/desktop_media_list.h File chrome/browser/media/desktop_media_list.h (right): https://codereview.chromium.org/89683003/diff/40001/chrome/browser/media/desktop_media_list.h#newcode23 chrome/browser/media/desktop_media_list.h:23: virtual ~Observer() {} On 2013/12/02 15:37:46, sky wrote: > ...
7 years ago (2013-12-02 20:38:57 UTC) #3
sky
LGTM
7 years ago (2013-12-02 22:12:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/89683003/160001
7 years ago (2013-12-02 23:25:18 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=195674
7 years ago (2013-12-03 01:51:54 UTC) #6
Sergey Ulanov
7 years ago (2013-12-03 02:30:21 UTC) #7
Message was sent while issue was closed. 
Committed patchset #7 manually as r238274 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698