Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 896823002: [Manifest] Update a RenderFrame's Manifest when navigated. (Closed)

Created:
5 years, 10 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 10 months ago
Reviewers:
Miguel Garcia, benwells
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Manifest] Update a RenderFrame's Manifest when navigated. BUG=454457 Committed: https://crrev.com/2faf5ef9b44d6f03ea3c754c58f0a9faff981a8f Cr-Commit-Position: refs/heads/master@{#314534}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M content/browser/manifest/manifest_browsertest.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M content/renderer/manifest/manifest_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/manifest/manifest_manager.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mlamouri (slow - plz ping)
5 years, 10 months ago (2015-02-03 18:21:34 UTC) #2
Miguel Garcia
lgtm
5 years, 10 months ago (2015-02-04 09:56:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896823002/1
5 years, 10 months ago (2015-02-04 10:03:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 10:53:20 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 10:54:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2faf5ef9b44d6f03ea3c754c58f0a9faff981a8f
Cr-Commit-Position: refs/heads/master@{#314534}

Powered by Google App Engine
This is Rietveld 408576698