Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 896803003: Credential Manager: Respect the 'skip_zero_click' flag for 'request()'. (Closed)

Created:
5 years, 10 months ago by Mike West
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, gcasto+watchlist_chromium.org, jam, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@rename
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Credential Manager: Respect the 'skip_zero_click' flag for 'request()'. Now that we're setting the 'skip_zero_click' flag in 'notifySignedOut', we ought to respect it when generating the list of items for 'request()' BUG=450581 R=vabr@chromium.org, vasilii@chromium.org NOTRY=true Committed: https://crrev.com/8b92b6ea59cebc775ac2fc455db019ce469306aa Cr-Commit-Position: refs/heads/master@{#315287}

Patch Set 1 #

Total comments: 5

Patch Set 2 : Feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -8 lines) Patch
M components/password_manager/content/browser/credential_manager_dispatcher.cc View 2 chunks +18 lines, -7 lines 0 comments Download
M components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc View 1 3 chunks +55 lines, -1 line 0 comments Download

Messages

Total messages: 15 (4 generated)
Mike West
Would one of you two mind taking a look? Note that this depends on the ...
5 years, 10 months ago (2015-02-09 10:16:45 UTC) #1
vabr (Chromium)
This LGTM. Cheers, Vaclav https://codereview.chromium.org/896803003/diff/1/components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc File components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc (right): https://codereview.chromium.org/896803003/diff/1/components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc#newcode429 components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc:429: EXPECT_EQ(CredentialType::CREDENTIAL_TYPE_LOCAL, get<1>(send_param).type); Should you also ...
5 years, 10 months ago (2015-02-09 10:31:13 UTC) #2
vasilii
Do you have a test with two skip_zero_click==false credentials? https://codereview.chromium.org/896803003/diff/1/components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc File components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc (right): https://codereview.chromium.org/896803003/diff/1/components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc#newcode428 components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc:428: ...
5 years, 10 months ago (2015-02-09 10:44:07 UTC) #3
Mike West
On 2015/02/09 at 10:44:07, vasilii wrote: > Do you have a test with two skip_zero_click==false ...
5 years, 10 months ago (2015-02-09 10:46:01 UTC) #4
Mike West
Thanks, vabr@! Vasilii, are you happy with patchset #2? https://codereview.chromium.org/896803003/diff/1/components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc File components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc (right): https://codereview.chromium.org/896803003/diff/1/components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc#newcode428 components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc:428: ...
5 years, 10 months ago (2015-02-09 10:51:50 UTC) #6
vasilii
lgtm
5 years, 10 months ago (2015-02-09 10:54:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896803003/20001
5 years, 10 months ago (2015-02-09 11:35:12 UTC) #9
Mike West
On 2015/02/09 at 11:35:12, commit-bot wrote: > CQ is trying da patch. Follow status at ...
5 years, 10 months ago (2015-02-09 13:31:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896803003/20001
5 years, 10 months ago (2015-02-09 13:32:21 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-09 13:33:29 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 13:34:07 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8b92b6ea59cebc775ac2fc455db019ce469306aa
Cr-Commit-Position: refs/heads/master@{#315287}

Powered by Google App Engine
This is Rietveld 408576698