Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Issue 896793004: Don't report DRP request error code UMA when LOAD_BYPASS_PROXY is set. (Closed)

Created:
5 years, 10 months ago by sclittle
Modified:
5 years, 10 months ago
Reviewers:
bengr
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't report DRP request error code UMA when LOAD_BYPASS_PROXY is set. This fixes a reporting bug with the DataReductionProxy.RequestCompletionErrorCodes histograms. Previously, these histograms counted requests that encountered errors when retrying the request after bypassing the data reduction proxy (e.g. block-once). This is incorrect because the error did not occur when trying to use the DRP. The fix is to ignore requests that completed with the LOAD_BYPASS_PROXY load flag, since these requests did not use the DRP even if the proxy_server() in the URLRequest is still set to the DRP. BUG=454947 Committed: https://crrev.com/fb93bf47152d82d4403f73fc74b4f560255d16ab Cr-Commit-Position: refs/heads/master@{#314432}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -17 lines) Patch
M components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats.cc View 1 chunk +6 lines, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats_unittest.cc View 3 chunks +25 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sclittle
bengr: all Thanks in advance
5 years, 10 months ago (2015-02-03 21:44:04 UTC) #2
bengr
lgtm
5 years, 10 months ago (2015-02-03 21:54:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896793004/1
5 years, 10 months ago (2015-02-03 21:56:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 23:28:43 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 23:29:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb93bf47152d82d4403f73fc74b4f560255d16ab
Cr-Commit-Position: refs/heads/master@{#314432}

Powered by Google App Engine
This is Rietveld 408576698