Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 896783002: Turn throws into basic block terminators. (Closed)

Created:
5 years, 10 months ago by Michael Starzinger
Modified:
5 years, 10 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_trycatch-1
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Turn throws into basic block terminators. R=bmeurer@chromium.org TEST=cctest/test-run-jsexceptions/Throw Committed: https://crrev.com/9d6f55b08a5a34eac6af3a0b7405d5756628c618 Cr-Commit-Position: refs/heads/master@{#26406}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Patch
M src/compiler/ast-graph-builder.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/compiler/scheduler.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-jsexceptions.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Starzinger
5 years, 10 months ago (2015-02-03 12:33:34 UTC) #1
Benedikt Meurer
LGTM
5 years, 10 months ago (2015-02-03 14:49:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896783002/1
5 years, 10 months ago (2015-02-03 14:53:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 15:22:48 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 15:23:10 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d6f55b08a5a34eac6af3a0b7405d5756628c618
Cr-Commit-Position: refs/heads/master@{#26406}

Powered by Google App Engine
This is Rietveld 408576698