Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1593)

Unified Diff: Source/core/svg/SVGAnimationElement.cpp

Issue 896773002: [svg2] Make 'x' and 'y' presentation attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: cleanup Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/SVGAnimationElement.cpp
diff --git a/Source/core/svg/SVGAnimationElement.cpp b/Source/core/svg/SVGAnimationElement.cpp
index f31869e6a2cd5b9fda9479b15e8fafff952a3437..a29fd6ba3f80b3426fa7c92e9f3282893b135335 100644
--- a/Source/core/svg/SVGAnimationElement.cpp
+++ b/Source/core/svg/SVGAnimationElement.cpp
@@ -368,6 +368,9 @@ bool SVGAnimationElement::isTargetAttributeCSSProperty(SVGElement* targetElement
{
ASSERT(targetElement);
+ if (!targetElement->isPresentationAttribute(attributeName))
fs 2015/02/04 13:24:53 <to be written>
fs 2015/02/05 09:37:21 Ehrm... And here I intended to write something lik
Erik Dahlström (inactive) 2015/02/05 16:09:02 Argh, yes, and now I remember why the whole ApplyC
+ return false;
+
return SVGElement::isAnimatableCSSProperty(attributeName);
}

Powered by Google App Engine
This is Rietveld 408576698