Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1425)

Unified Diff: Source/core/svg/SVGElement.h

Issue 896773002: [svg2] Make 'x' and 'y' presentation attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGAnimationElement.cpp ('k') | Source/core/svg/SVGElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGElement.h
diff --git a/Source/core/svg/SVGElement.h b/Source/core/svg/SVGElement.h
index 56cdf0e16e7be14ec5d05be80297da01fa7261ed..3c744a8060727ee8ba6dd04e65a8263d90111672 100644
--- a/Source/core/svg/SVGElement.h
+++ b/Source/core/svg/SVGElement.h
@@ -44,6 +44,7 @@ class SVGDocumentExtensions;
class SVGElement;
class SVGElementRareData;
class SVGFitToViewBox;
+class SVGLength;
class SVGSVGElement;
class SVGUseElement;
@@ -66,6 +67,8 @@ public:
virtual String title() const override;
bool hasRelativeLengths() const { return !m_elementsWithRelativeLengths.isEmpty(); }
static bool isAnimatableCSSProperty(const QualifiedName&);
+ virtual bool isPresentationAttributeWithSVGDOM(const QualifiedName&) const { return false; }
+
enum CTMScope {
NearestViewportScope, // Used by SVGGraphicsElement::getCTM()
ScreenScope, // Used by SVGGraphicsElement::getScreenCTM()
@@ -106,6 +109,7 @@ public:
void invalidateSVGAttributes() { ensureUniqueElementData().m_animatedSVGAttributesAreDirty = true; }
void invalidateSVGPresentationAttributeStyle() { ensureUniqueElementData().m_presentationAttributeStyleIsDirty = true; }
+ void addSVGLengthPropertyToPresentationAttributeStyle(MutableStylePropertySet*, CSSPropertyID, SVGLength&);
const WillBeHeapHashSet<RawPtrWillBeWeakMember<SVGElement> >& instancesForElement() const;
void mapInstanceToElement(SVGElement*);
@@ -188,6 +192,8 @@ public:
static const AtomicString& eventParameterName();
+ virtual bool isPresentationAttribute(const QualifiedName&) const override;
+
protected:
SVGElement(const QualifiedName&, Document&, ConstructionType = CreateSVGElement);
@@ -200,7 +206,6 @@ protected:
virtual void attributeChanged(const QualifiedName&, const AtomicString&, AttributeModificationReason = ModifiedDirectly) override;
- virtual bool isPresentationAttribute(const QualifiedName&) const override;
virtual void collectStyleForPresentationAttribute(const QualifiedName&, const AtomicString&, MutableStylePropertySet*) override;
virtual InsertionNotificationRequest insertedInto(ContainerNode*) override;
« no previous file with comments | « Source/core/svg/SVGAnimationElement.cpp ('k') | Source/core/svg/SVGElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698