Source/core/svg/SVGForeignObjectElement.h - Issue 896773002: [svg2] Make 'x' and 'y' presentation attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGForeignObjectElement.h

Issue 896773002: [svg2] Make 'x' and 'y' presentation attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: circling back towards patchset #1 again Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGForeignObjectElement.h

diff --git a/Source/core/svg/SVGForeignObjectElement.h b/Source/core/svg/SVGForeignObjectElement.h

index cd89c9f14582e4233adb64e6ed2865249c7d0f4e..bd6e8ff0b0dc53815182cc84d2dd5c06ef92d853 100644

--- a/Source/core/svg/SVGForeignObjectElement.h

+++ b/Source/core/svg/SVGForeignObjectElement.h

@@ -47,6 +47,7 @@ private:

bool isSupportedAttribute(const QualifiedName&);

virtual void parseAttribute(const QualifiedName&, const AtomicString&) override;

virtual bool isPresentationAttribute(const QualifiedName&) const override;

+ virtual bool isPresentationAttributeWithSVGDOM(const QualifiedName&) const override;

virtual void collectStyleForPresentationAttribute(const QualifiedName&, const AtomicString&, MutableStylePropertySet*) override;

virtual void svgAttributeChanged(const QualifiedName&) override;