Source/core/svg/SVGImageElement.h - Issue 896773002: [svg2] Make 'x' and 'y' presentation attributes

Side by Side Diff: Source/core/svg/SVGImageElement.h

Issue 896773002: [svg2] Make 'x' and 'y' presentation attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: cleanup Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org>	2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org>

3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>	3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>

4 *	4 *

5 * This library is free software; you can redistribute it and/or	5 * This library is free software; you can redistribute it and/or

6 * modify it under the terms of the GNU Library General Public	6 * modify it under the terms of the GNU Library General Public

7 * License as published by the Free Software Foundation; either	7 * License as published by the Free Software Foundation; either

8 * version 2 of the License, or (at your option) any later version.	8 * version 2 of the License, or (at your option) any later version.

9 *	9 *

10 * This library is distributed in the hope that it will be useful,	10 * This library is distributed in the hope that it will be useful,

(...skipping 37 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
48 SVGAnimatedLength* height() const { return m_height.get(); }	48 SVGAnimatedLength* height() const { return m_height.get(); }

49 SVGAnimatedPreserveAspectRatio* preserveAspectRatio() { return m_preserveAsp ectRatio.get(); }	49 SVGAnimatedPreserveAspectRatio* preserveAspectRatio() { return m_preserveAsp ectRatio.get(); }

50	50

51 private:	51 private:

52 explicit SVGImageElement(Document&);	52 explicit SVGImageElement(Document&);

53	53

54 virtual bool isStructurallyExternal() const override { return !hrefString(). isNull(); }	54 virtual bool isStructurallyExternal() const override { return !hrefString(). isNull(); }

55	55

56 bool isSupportedAttribute(const QualifiedName&);	56 bool isSupportedAttribute(const QualifiedName&);

57 virtual void parseAttribute(const QualifiedName&, const AtomicString&) overr ide;	57 virtual void parseAttribute(const QualifiedName&, const AtomicString&) overr ide;

58 virtual bool isPresentationAttribute(const QualifiedName&) const override;	58 virtual bool isPresentationAttribute(const QualifiedName&) const override fi nal;
	fs 2015/02/04 13:24:53 This class is final, so the final qualifiers are r This class is final, so the final qualifiers are redundant. Erik Dahlström (inactive) 2015/02/05 16:09:02 Done. Show quoted text On 2015/02/04 13:24:53, fs wrote: > This class is final, so the final qualifiers are redundant. Done.
59 virtual void collectStyleForPresentationAttribute(const QualifiedName&, cons t AtomicString&, MutableStylePropertySet*) override;	59 virtual void collectStyleForPresentationAttribute(const QualifiedName&, cons t AtomicString&, MutableStylePropertySet*) override final;

	60

60 virtual void svgAttributeChanged(const QualifiedName&) override;	61 virtual void svgAttributeChanged(const QualifiedName&) override;

61	62

62 virtual void attach(const AttachContext& = AttachContext()) override;	63 virtual void attach(const AttachContext& = AttachContext()) override;

63 virtual InsertionNotificationRequest insertedInto(ContainerNode*) override;	64 virtual InsertionNotificationRequest insertedInto(ContainerNode*) override;

64	65

65 virtual RenderObject* createRenderer(RenderStyle*) override;	66 virtual RenderObject* createRenderer(RenderStyle*) override;

66	67

67 virtual const AtomicString imageSourceURL() const override;	68 virtual const AtomicString imageSourceURL() const override;

68	69

69 virtual bool haveLoadedRequiredResources() override;	70 virtual bool haveLoadedRequiredResources() override;

70	71

71 virtual bool selfHasRelativeLengths() const override;	72 virtual bool selfHasRelativeLengths() const override;

72 virtual void didMoveToNewDocument(Document& oldDocument) override;	73 virtual void didMoveToNewDocument(Document& oldDocument) override;

73 SVGImageLoader& imageLoader() { return *m_imageLoader; }	74 SVGImageLoader& imageLoader() { return *m_imageLoader; }

74	75

75 RefPtrWillBeMember<SVGAnimatedLength> m_x;	76 RefPtrWillBeMember<SVGAnimatedLength> m_x;

76 RefPtrWillBeMember<SVGAnimatedLength> m_y;	77 RefPtrWillBeMember<SVGAnimatedLength> m_y;

77 RefPtrWillBeMember<SVGAnimatedLength> m_width;	78 RefPtrWillBeMember<SVGAnimatedLength> m_width;

78 RefPtrWillBeMember<SVGAnimatedLength> m_height;	79 RefPtrWillBeMember<SVGAnimatedLength> m_height;

79 RefPtrWillBeMember<SVGAnimatedPreserveAspectRatio> m_preserveAspectRatio;	80 RefPtrWillBeMember<SVGAnimatedPreserveAspectRatio> m_preserveAspectRatio;

80	81

81 OwnPtrWillBeMember<SVGImageLoader> m_imageLoader;	82 OwnPtrWillBeMember<SVGImageLoader> m_imageLoader;

82 bool m_needsLoaderURIUpdate : 1;	83 bool m_needsLoaderURIUpdate : 1;

83 };	84 };

84	85

85 } // namespace blink	86 } // namespace blink

86	87

87 #endif // SVGImageElement_h	88 #endif // SVGImageElement_h

OLD	NEW