pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart - Issue 896763003: dart2js: emit noSuchMethod stubs in the new emitter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart

Issue 896763003: dart2js: emit noSuchMethod stubs in the new emitter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Forgot to save. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart ('k') | pkg/compiler/lib/src/js_emitter/program_builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart

index 37241459e02d190e9ca1fc1f404f0d3fbd833fe5..93f866bdc9ebea2f244e8bfbecd2c8b7d36dbb5a 100644

--- a/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart

@@ -49,11 +49,10 @@ class NsmEmitter extends CodeEmitterHelper {

isTrivialNsmHandler(type, argNames, selector, jsName) &&

reflectionName == null) {

trivialNsmHandlers.add(selector);

- }

- jsAst.Expression method = generator.generateStubForNoSuchMethod(selector);

- if (method != null) {

- addProperty(jsName, method);

+ } else {

+ StubMethod method =

+ generator.generateStubForNoSuchMethod(jsName, selector);

+ addProperty(method.name, method.code);

if (reflectionName != null) {

bool accessible = compiler.world.allFunctions.filter(selector).any(

(Element e) => backend.isAccessibleByReflection(e));